This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67593 - core does not have any public packages
Summary: core does not have any public packages
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2005-10-26 14:51 UTC by Jaroslav Tulach
Modified: 2008-12-22 17:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Changes in project.xml and golden files (4.10 KB, patch)
2005-10-26 14:51 UTC, Jaroslav Tulach 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2005-10-26 14:51:01 UTC 
As discussed on nbdev recently there are still people using org.netbeans.core 
as real API and they do not realize that this is something that they shall not 
rely on. 
 
In 5.0 we needed to bump the major version of core due to its split to 
core/startup and core/bootstrap and that is why it seems like good idea to 
also restrict uncontrolled access to its packages. 
 
Let's make the package friend, with list of current modules that need access 
to them from netbeans.org. That way we prevent accidental usages of the core 
public package and warn people to not do something they shall not do. Of 
course if they really wish, there is always a chance to use impl 
dependencies...
Comment 1 Jaroslav Tulach 2005-10-26 14:51:28 UTC 
Created attachment 26361 [details]
Changes in project.xml and golden files
Comment 2 Jesse Glick 2005-10-26 18:54:10 UTC 
Gee, I wish I had as many friends as core... maybe we should do something about
all those bogus usages.

BTW re. project.xml diff - the diff exhibits an XML whitespace bug which I
thought I fixed a couple of weeks ago in dev builds. Are you just using an older
IDE build?
Comment 3 Jaroslav Tulach 2005-10-27 07:12:10 UTC 
Yes, cleaning the friends is desirable. But we can leave it for next version  
as that will not be incompatible change, I think.  
  
Yesterday morning I was using build from Oct10, at the evening I was using  
the newest build. It is likely the project.xml was generated by the older one.
Comment 4 Jaroslav Tulach 2005-11-01 08:04:42 UTC 
I'll apply tomorrow.
Comment 5 Jaroslav Tulach 2005-11-04 08:17:48 UTC 
"#67593: core never had public packages, so let's make them friend ones" 
 
Checking in core/nbproject/project.xml; 
/cvs/core/nbproject/project.xml,v  <--  project.xml 
new revision: 1.12; previous revision: 1.11 
done 
Checking in ide/golden/friend-packages.txt; 
/cvs/ide/golden/friend-packages.txt,v  <--  friend-packages.txt 
new revision: 1.3; previous revision: 1.2 
done 
Checking in ide/golden/public-packages.txt; 
/cvs/ide/golden/public-packages.txt,v  <--  public-packages.txt 
new revision: 1.49; previous revision: 1.48
Comment 6 Jaromir Uhrik 2006-01-16 15:45:14 UTC 
Marking this issue as VERIFIED since the issue reporter == issue owner.