This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67584 - Check zip with sources of platform while adding to NBPM
Summary: Check zip with sources of platform while adding to NBPM
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-26 13:37 UTC by Tomas Danek
Modified: 2005-12-05 14:23 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2005-10-26 13:37:18 UTC 
from issue 62773:
> Behavior should be that any
> dir or ZIP should be accepted in the filechooser so long as either
> ...
> 2. For a ZIP file only, it contains "nbbuild" as a subsubdir, in which case the
> parent is treated as the root

Filechooser currently accepts whatever ZIP you like..even empty:( P4 since not
many users are trying to add corrupted/wrong ZIP, they usually download one from
web and simply add it.
Comment 1 Martin Krauskopf 2005-11-09 14:47:39 UTC 
Presuambly easy, started...
Comment 2 Martin Krauskopf 2005-11-09 15:52:11 UTC 
Fixed. Leaving addition of arbitrary existing directory since the user would
want to add Suite (and maybe more). I'm not sure know if this feature even work.

Checking in queries/GlobalSourceForBinaryImpl.java; 1.3 -> 1.4;
Checking in ui/platform/Bundle.properties; 1.12 -> 1.13;
Checking in ui/platform/NbPlatformCustomizerSources.java; 1.6 -> 1.7;
Comment 3 Jesse Glick 2005-11-10 00:54:34 UTC 
The specification requires that NBPM accept sources for a suite as well as the
NB Platform for association with a derived platform. If that doesn't work,
please file a separate bug. It is critical for the success of the "chaining
suites" scenario as documented in harness/README.
Comment 4 Martin Krauskopf 2005-11-10 02:58:54 UTC 
It'll accept it. Another question is wheter it will be effectivelly used by
SFBQI. By the GlobalSFBQI not - it "accepts" only zips containing NB_BASED_APP
sources. Not sure about "Project" SFBQI. I'll check it tomorrow.
Comment 5 Martin Krauskopf 2005-11-22 14:07:59 UTC 
> Chaining Suites

I've been playing with it today and it works automagically.
o.n.m.java.project.ProjectSourceForBinaryQuery calls after few steps
BinaryEntry.getSourceLocation() which in turns
NbPlatform.getSourceLocationOfModule() which is able to handle the query for a
given jar when suite is part of sources list. So presuabmly
ModuleList.findOrCreateModuleListFromSuiteWithoutBinaries() does the job.
Comment 6 Tomas Danek 2005-12-05 12:38:34 UTC 
I do not have access to any derived platforms (and their sources) :( but
verified with NB platorm sources.
Comment 7 Tomas Danek 2005-12-05 12:38:51 UTC 
I do not have access to any derived platforms (and their sources) :( but
verified with NB platform sources.
Comment 8 Tomas Danek 2005-12-05 13:36:59 UTC 
Petre, will you try suite chaining scenario?? Thanks in advance
Comment 9 Tomas Danek 2005-12-05 14:23:29 UTC 
Ok, I played with this a little by myself. Code completion, ALT+O, ... works ok
for chaining suite scenario from harness/README, so definitly verified.