This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 66821 - NPE in cvss CommitBuilder
Summary: NPE in cvss CommitBuilder
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
: 67840 68325 (view as bug list)
Depends on:
Blocks: 68331
  Show dependency tree
 
Reported: 2005-10-14 16:11 UTC by David Strupl
Modified: 2007-01-04 17:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Strupl 2005-10-14 16:11:51 UTC
>Log Session: Friday, October 14, 2005 5:01:42 PM CEST
>System Info:
  Product Version       = NetBeans IDE Dev (Build 051011)
  Operating System      = Linux version 2.6.10-1.771_FC2 running on i386
  Java; VM; Vendor      = 1.5.0_04; Java HotSpot(TM) Client VM 1.5.0_04-b05; Sun
Microsystems Inc.
  Java Home             = /usr/local/java/jdk1.5.0_04/jre
 
Deleted some files in the "Files" view. Tried to commit the changes:

INFORMATIONAL *********** Exception occurred ************ at 5:07 PM on Oct 14, 2005
java.lang.NullPointerException
        at
org.netbeans.modules.versioning.system.cvss.ExecutorSupport.fileInfoGenerated(ExecutorSupport.java:253)
        at
org.netbeans.lib.cvsclient.event.FileInfoEvent.fireEvent(FileInfoEvent.java:55)
        at
org.netbeans.lib.cvsclient.event.EventManager.fireCVSEvent(EventManager.java:118)
[catch] at
org.netbeans.lib.cvsclient.command.commit.CommitBuilder.outputDone(CommitBuilder.java:74)
        at
org.netbeans.lib.cvsclient.command.commit.CommitBuilder.parseLine(CommitBuilder.java:89)
        at
org.netbeans.lib.cvsclient.command.BuildableCommand.messageSent(BuildableCommand.java:108)
        at
org.netbeans.lib.cvsclient.event.MessageEvent.fireEvent(MessageEvent.java:96)
        at
org.netbeans.lib.cvsclient.event.EventManager.fireCVSEvent(EventManager.java:118)
        at
org.netbeans.lib.cvsclient.response.MessageResponse.process(MessageResponse.java:58)
        at org.netbeans.lib.cvsclient.Client.handleResponse(Client.java:513)
        at org.netbeans.lib.cvsclient.Client.processRequests(Client.java:463)
        at
org.netbeans.lib.cvsclient.command.commit.CommitCommand.execute(CommitCommand.java:290)
        at org.netbeans.lib.cvsclient.Client.executeCommand(Client.java:572)
        at
org.netbeans.modules.versioning.system.cvss.CommandRunnable$1.run(CommandRunnable.java:61)
        at java.lang.Thread.run(Thread.java:595)
Comment 1 Maros Sandor 2005-10-17 10:49:29 UTC
Can you reproduce it or was it just one-time case? How many files did you
delete? All of them were versioned? When committing, were there other files that
went with the commit or only those deleted files?
Comment 2 David Strupl 2005-10-17 11:37:21 UTC
Fortunatelly for me it was just one time event (when commiting to nb.org cvs). I
was trying to commit many files - some of them succeeded. After it happened the
whole status was somehow wrong - I had to commit the files that did not succeed
individually. Commiting the whole batch of files did not work until nb restart.
Sorry but I don't want to reproduce this behaviour on nb.org CVS and I don't
have any testing repository ;-((
It happened when I was trying to commit this folder (actually couple of folders
up to this one but it failed on some of these files)
http://www.netbeans.org/source/browse/openidex/enode/src/org/netbeans/modules/enode/
Not sure whether you can get some info from the server log there.
Comment 3 _ pkuzel 2005-10-18 13:48:42 UTC
-J-DcvsClientLog=/tmp/cvsLog output would be helpfull. Server responded with
unexpected text messages sequence.

It's similar to issue #65387.

Hotfix, to simply ignore incomplete FileInfos in ES, possibly leaving a file
unrefreshed.
Comment 4 Maros Sandor 2005-10-19 14:22:54 UTC
We do not have enough information to fix this. Client log files would be very
helpful as Petr mentioned. We will implement a workaroud for FCS in case we
won't be able to reproduce it.
Comment 5 Maros Sandor 2005-11-01 09:28:38 UTC
*** Issue 67840 has been marked as a duplicate of this issue. ***
Comment 6 Maros Sandor 2005-11-09 14:08:17 UTC
*** Issue 68325 has been marked as a duplicate of this issue. ***
Comment 7 Maros Sandor 2005-11-09 14:40:54 UTC
I can reproduce it by deleting a folder (with a file in it) and committing.
Comment 8 Peter Pis 2005-11-10 13:21:11 UTC
This showstopper, please fix this into "release50_beta2" branch. Thanks.
Comment 9 Maros Sandor 2005-11-10 16:43:35 UTC
Improved server response messages processing.

/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/Client.java,v
 <--  Client.java
new revision: 1.92; previous revision: 1.91
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/ClientServices.java,v
 <--  ClientServices.java
new revision: 1.25; previous revision: 1.24
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/event/EventManager.java,v
 <--  EventManager.java
new revision: 1.11; previous revision: 1.10
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/command/commit/CommitBuilder.java,v
 <--  CommitBuilder.java
new revision: 1.15; previous revision: 1.14
Comment 10 Peter Pis 2005-11-11 09:26:00 UTC
Verified in trunk, please commit fix into "release50_beta2" branch too. Thanks.
Comment 11 Maros Sandor 2005-11-11 13:01:11 UTC
Integrated.

/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/Client.java,v
 <--  Client.java
new revision: 1.91.4.1; previous revision: 1.91
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/ClientServices.java,v
 <--  ClientServices.java
new revision: 1.24.4.1; previous revision: 1.24
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/event/EventManager.java,v
 <--  EventManager.java
new revision: 1.10.6.1; previous revision: 1.10
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/command/commit/CommitBuilder.java,v
 <--  CommitBuilder.java
new revision: 1.14.10.1; previous revision: 1.14
Comment 12 Peter Pis 2005-11-14 08:40:16 UTC
Verified in NetBeans IDE 5.0 Beta 2 (Build 200511131001)