This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 66732 - [50cat] Debug Fix button missing from debugger toolbar.
Summary: [50cat] Debug Fix button missing from debugger toolbar.
Status: VERIFIED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 5.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: REGRESSION
: 66734 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-13 16:56 UTC by gugrim
Modified: 2005-10-18 09:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gugrim 2005-10-13 16:56:24 UTC 
[ BUILD # : 200510122200 ]
[ JDK VERSION : 1.5.0_04 ]

For some reason it has been removed. It can be added ahain but it will only stay put during the current NB session. After a restart it is gone.
Comment 1 Unknown 2005-10-13 16:59:34 UTC 
*** Issue 66734 has been marked as a duplicate of this issue. ***
Comment 2 Martin Entlicher 2005-10-14 09:52:24 UTC 
It was not removed intentionally, it just disappeared for some reason. I was
reimplementing the actions....
It's a regression, it seems to be caused by the fix of issue #57494.
Comment 3 Martin Entlicher 2005-10-14 15:28:50 UTC 
Well, I have no idea what's wrong. If I associate a shortcut with the action,
it's displayed correctly in the Toolbar.
Also, when I call
((InstanceDataObject) ((DataShadow) dob).getOriginal()).instanceCreate()
where "dob" is the DataObject that represents the shadow to
"org-netbeans-modules-debugger-ui-actions-FixAction" which is passed to
org.openide.awt.Toolbar.Folder.acceptDataObject(dob), then the correct instance
of DebuggerAction is created.
Right after that
((org.openide.cookies.InstanceCookie.Of)cookie).instanceOf(javax.swing.Action.class)==true

The shortcurs forces to create the instances, thus that explains why it works
fine for actions with shortcuts.

But InstanceCookie.Of.instanceOf() ... should return correct results regardless
of whether the instance was created or not... ??

I've used the following pattern to specify the action, which is suggested at
http://docs.spadac.com/ext/netbeans/www.netbeans.org/about/books/html/apis-c_theOpenApis.html

<file name="com-mymodule-MyInterface.instance">
  <attr name="instanceOf" stringvalue="com.mymodule.MyClass"/>
  <attr name="instanceCreate" methodvalue="com.mymodule.AnyClass.createMyClass"/>
  <attr name="instanceClass" methodvalue="com.mymodule.MyInterface">
</file>

Can you please advice what's wrong? Thanks.
Comment 4 Martin Entlicher 2005-10-14 15:29:25 UTC 
Likely DataSystem issue??
Comment 5 Martin Entlicher 2005-10-14 17:44:02 UTC 
The example is BAD !!!

It should be:

<file name="com-mymodule-MyInterface.instance">
  <attr name="instanceClass" stringvalue="com.mymodule.MyClass"/>
  <attr name="instanceCreate" methodvalue="com.mymodule.AnyClass.createMyClass"/>
  <attr name="instanceOf" methodvalue="com.mymodule.MyInterface">
</file>

Then it works. Please document this, I've lost a *LOT* of time with such a
crappy thing.
Comment 6 Martin Entlicher 2005-10-14 18:37:46 UTC 
Fixed:

/cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml,v
 <--  mf-layer.xml
new revision: 1.30; previous revision: 1.29
Comment 7 gugrim 2005-10-18 09:43:42 UTC 
Tested with build 200510171800.