This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 66540 - persistence help missing
Summary: persistence help missing
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Rochelle Raccah
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-11 23:54 UTC by John Jullion-ceccarelli
Modified: 2005-11-10 11:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
link check of SJS app server help (21.77 KB, text/plain)
2005-10-31 15:55 UTC, Patrick Keegan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Jullion-ceccarelli 2005-10-11 23:54:01 UTC
Open the Map Relationship Field wizard from sun-ejb-jar.xml->Cmp Mappings and
click the Help button. You get a blank page. Same with all other
persistence-supplied dialogs.
Comment 1 Patrick Keegan 2005-10-14 17:17:25 UTC
This might be from an out-of-date JavaHelp search database. The JavaHelp search
database should be created at build time. Issue 63899 is similar.
Comment 2 _ ludo 2005-10-14 19:39:14 UTC
Rochelle is not available for now. I'll talk to her next week.
Comment 3 Patrick Keegan 2005-10-31 15:55:01 UTC
Created attachment 26491 [details]
link check of SJS app server help
Comment 4 Patrick Keegan 2005-10-31 16:04:58 UTC
mystery possibly solved. I just ran the check-javahelp target on the plugin help
set, which reports of some malformed XML and dozens of broken links between map
IDs in the persistence help set. I assume fixing one line of XML 

<mapID target="tphelp.ejbconcepts1" url="overview/ejbconcepts1.html"> ->
<mapID target="tphelp.ejbconcepts1" url="overview/ejbconcepts1.html" />

will solve a lot of the problems
Comment 5 Rochelle Raccah 2005-11-01 01:13:25 UTC
Yes, Ludo had already found this and we corrected it (though I'm not sure if
it's checked in yet).  After that correction, some of the help could be shown
but other help buttons resulted in a blank page.
Comment 6 Rochelle Raccah 2005-11-03 20:48:15 UTC
The problem was a missing registration of the helpset in the layer.  Ludo is
adding it to the plugin layer.
Comment 7 _ ludo 2005-11-03 21:34:06 UTC
fixed
***** CVS exited normally with code 1 *****

cvs commit -m "Fix for P2
http://www.netbeans.org/issues/show_bug.cgi?id=66540\ncannot see some ..." --
layer.xml (in directory
C:\acvs\nb_all\serverplugins\sun\appsrv81\src\org\netbeans\modules\j2ee\sun\ide\j2ee\)
Checking in layer.xml;
/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/layer.xml,v
 <--  layer.xml
new revision: 1.8; previous revision: 1.7
done

***** CVS exited normally with code 0 *****

cvs add -- helpset-decl.xml (in directory
C:\acvs\nb_all\serverplugins\sun\appsrv81\src\org\netbeans\modules\j2ee\sun\ide\j2ee\)
cvs server: scheduling file `helpset-decl.xml' for addition
cvs server: use 'cvs commit' to add this file permanently

***** CVS exited normally with code 0 *****

cvs commit -m "Fix for P2
http://www.netbeans.org/issues/show_bug.cgi?id=66540\ncannot see some ..." --
helpset-decl.xml (in directory
C:\acvs\nb_all\serverplugins\sun\appsrv81\src\org\netbeans\modules\j2ee\sun\ide\j2ee\)
RCS file:
/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/helpset-decl.xml,v
done
Checking in helpset-decl.xml;
/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/helpset-decl.xml,v
 <--  helpset-decl.xml
initial revision: 1.1
done
Comment 8 _ ludo 2005-11-03 21:34:25 UTC
f
Comment 9 Patrick Keegan 2005-11-04 11:44:27 UTC
When doing a link check, I get similar results to the link check I posted
earlier. Is there anything in particular that I need to clean and rebuild to get
the proper persistence-help.jar?
Comment 10 Rochelle Raccah 2005-11-04 22:07:16 UTC
The persistence .hs file is for a complete helpset, only a subset of which is
used in the plugin.  So the broken links point to files which were intentionally
removed from the jar for the plugin.
Comment 11 Patrick Keegan 2005-11-07 19:04:18 UTC
Could you then make corresponding changes to the map file? It is horrible to try
to debug missing links when there are dozens of ones that don't apply to us.
Comment 12 Rochelle Raccah 2005-11-09 20:57:44 UTC
For this release, no.  Just ignore broken links in the map file.  If you have
broken links in the other files, it's a definite problem.  For next release,
we'll probably move some of the help to the plugin itself, or at least split
things differently, so we should be able to address this.
Comment 13 Patrick Keegan 2005-11-10 11:23:51 UTC
OK, splitting things would be very helpful