This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 65325 - Missing elements for websvc in DD's
Summary: Missing elements for websvc in DD's
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 8 (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ pcw
URL:
Keywords: REGRESSION
: 66357 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-29 11:45 UTC by Lukas Jungmann
Modified: 2005-10-20 16:10 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Stack trace when sniffing mime type on an XML file w/ invalid encoding. (5.61 KB, text/plain)
2005-10-15 19:22 UTC, _ pcw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Jungmann 2005-09-29 11:45:00 UTC
1. create new ejb/web project
2. create new websvc in it

=> no changes to DD's on the disk are made. When you "open" DD you can see
reference to ws endpoint there, but nothing is stored in file on the disk

   According to results of automated tests in worked correctly in build
200509211800 and it is not working from build 200509251800. There were no
automated tests between mentioned builds, so i cannot say exactly when it
happend for the first time.
Comment 1 _ ludo 2005-09-29 15:47:25 UTC
pcw: urgent to look at and fix.
Thanks
Comment 2 _ ludo 2005-09-29 17:39:25 UTC
David.Coldrick@xxx.COM said "
Problem does not appear in beta.
Regards,
David
"

So maybe it has been fixed?
Comment 3 _ pcw 2005-09-29 20:56:33 UTC
I will investigate this specific circumstance today.  I can say that there are
some failures in this general area ("do task in ide that affects sun-xxx.xml,
then immediately examine sun-xxx.xml on disk to see if necessary changes are
present"). Some might be regressions from 4.1, but some are broken in 4.1, as I
am now checking specifically this area in both versions.

As for not seeing it in beta --

1. This might have been fixed.
2. You may have changed the steps slightly or observed the file at a slightly
different point in the test cycle and so the problem could not be observed.
3. The original observation could have been premature and therefore invalid
(still could suggest a bug, but it is a different bug.)
Comment 4 _ pcw 2005-09-29 21:36:44 UTC
This bug is a regression caused by the fix for bug #63974.  Specifically, the
web service wizard used to create the webservices.xml entries for the new web
service first, and THEN add the servlet/ejb entries to the standard deployment
descriptor.

The fix for 63974 reversed this behavior so now when the servlet/ejb for this
service is created, the plugin attempts to find the corresponding entry in
webservices.xml so as to fill in the port information and it is not there yet.

This whole mechanism should be thought through a bit more before we decide what
the correct fix is.
Comment 5 _ pcw 2005-09-29 21:42:54 UTC
By way, if the "fix" for bug #63974 is present in the beta codebase, I would
expect you to see this incorrect behavior there as well.  I can't tell for sure
if that fix made it in, though a cursory glance suggests that it did.
Comment 6 Lukas Jungmann 2005-09-29 21:58:02 UTC
to pcw:
1. I don't think so. Beta was branched from trunk at "2005-09-20 18:00 GMT"
(quoted from email from RE) and it has been working correctly in trunk till the
build no. 200509211800, as I said above. I'm able to reproduce this also in
build 200509281800. It is also reproducible by hand.
2. Maybe, but i didn't make any major changes in my tests last month (see the
history of
http://www.netbeans.org/source/browse/j2ee/test/qa-functional/src/org/netbeans/test/j2ee/wizard/NewFileWizardsTest.java)
and I'm waiting 2.5seconds before i'm comparing files against golden files. 
3. I can let you know if I will be able to reproduce this in next build, if it
helps you
Comment 7 _ pcw 2005-09-30 02:00:51 UTC
Confirming that this problem does NOT happen in beta.

The cause of this regression is revision 1.28 to WebServiceWizard.java, which
was checked in on 9/22/05, while beta uses revision 1.27 of this file.
Comment 8 Lukas Jungmann 2005-10-10 13:56:46 UTC
*** Issue 66357 has been marked as a duplicate of this issue. ***
Comment 9 _ pcw 2005-10-10 18:53:24 UTC
I am considering adding a few new DConfigBeans bound to elements in
webservices.xml to manage the aspects of sun-web.xml/sun-ejb-jar.xml that depend
on the contexts of that file (webservices.xml).  This will remove any order
dependency for changes to web.xml/ejb-jar.xml and webservices.xml.  There will
be a side effect that new DConfigBeans = new UI for the config editor, but this
will also consolidate the web service related settings under one entry instead
of being spread out as they are now.
Comment 10 _ pcw 2005-10-15 19:22:15 UTC
Created attachment 25994 [details]
Stack trace when sniffing mime type on an XML file w/ invalid encoding.
Comment 11 _ pcw 2005-10-15 19:22:57 UTC
Please ignore last attachment pls.  Wrong bug.
Comment 12 Martin Grebac 2005-10-19 10:01:33 UTC
*** Issue 66357 has been marked as a duplicate of this issue. ***
Comment 13 _ pcw 2005-10-20 01:28:26 UTC
Committed two new DConfigBeans and related customizers that present a
per-webservice view of this aspect of configuration.  Fields presented are
webservice description (which has been removed from webapp and ejbjar
customizer) and webservice endpoints (which has been removed from servlet and
session ejb customizer).  Events regarding changes to webservices.xml have been
fixed (they were not working entirely correctly.

This should now be fixed.  Please file any issues under a new bug w/ explicit steps.
Comment 14 Lukas Jungmann 2005-10-20 16:10:30 UTC
great, thanks. v. in 20051020-0620