This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 65006 - Show warning dialog when building ZIP with no branding
Summary: Show warning dialog when building ZIP with no branding
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: UI
: 66071 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-23 15:11 UTC by pzajac
Modified: 2005-11-07 15:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pzajac 2005-09-23 15:11:57 UTC
[200509221800]
Steps to reproduce:
1) Create a module suite
2) Perform build zip on the module suite

It will be nice to show the same warning dialog like *Build JNLP* when branding
is not selected.
Comment 1 Jesse Glick 2005-09-23 17:18:09 UTC
Yes, it should.
Comment 2 Tomas Danek 2005-10-14 13:28:48 UTC
not only when performing build zip, but also when runnning suite,...
Comment 3 Jesse Glick 2005-10-14 19:28:10 UTC
Re. last comment - only when platform has no bin/netbeans, and reported already
in issue #66793.
Comment 4 pzajac 2005-10-18 17:39:26 UTC
*** Issue 66071 has been marked as a duplicate of this issue. ***
Comment 5 rrochat 2005-10-22 00:13:15 UTC
When I click on Build JNLP in 200510131600 and click 
on "Configure Application Name..." I expect to see
a dialog where I can type in the Application Name.
Instead, I see the suite's Properties dialog.
After clicking on the Application, I see that 
"Create Collection of Add-on Modules" is selected.
What's that mean? (The Help topic hasn't been updated
to match this new screen and I really don't know 
what this is.)
If I click on Create Standalone Application,
I can type in the Branding Name or 
Application Title.
So, which one is the alleged Application Name?

It's all close, but is not very intuitive at the
moment.  There are a variety of ways to make this
better, but possibly
1) Make the button and the label match (both should
be name or title)
2) Have "Application" selected when the Properties
dialog opens and possibly even change the radio button selection
to be "Create Standalone App"
3) update Help
Comment 6 Tomas Danek 2005-10-24 11:00:10 UTC
Sounds reasonable..
Comment 7 Jesse Glick 2005-10-24 16:13:13 UTC
The properties dialog got rearranged significantly so it is not surprising that
the older dialog was not updated to match.
Comment 8 Jesse Glick 2005-11-03 04:38:25 UTC
Will fix for 5.0.
Comment 9 Jesse Glick 2005-11-04 22:56:35 UTC
Fixed labels and so on to deal with the problems rrochat found...
Comment 10 Jesse Glick 2005-11-06 23:10:28 UTC
Fixed together w/ issue #65461:

committed   * Up-To-Date  1.21       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/Bundle.properties
committed   * Up-To-Date  1.11       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/SuiteActions.java
committed   * Up-To-Date  1.62       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/Bundle.properties
committed   * Up-To-Date  1.16       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteCustomizer.java
committed   * Up-To-Date  1.16       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteCustomizerBasicBranding.java
committed   * Up-To-Date  1.7        
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/jnlp/GenerateJNLPApplicationTest.java
committed   * Up-To-Date  1.3        
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/suite/BuildZipDistributionTest.java
Comment 11 Tomas Danek 2005-11-07 14:29:08 UTC
Original issue fixed, verified in trunk.
rrochat's request about preselecting Create Standalone Application radiobutton
would be nice, but no strong opinion on my side.
Comment 12 Jesse Glick 2005-11-07 15:38:45 UTC
The "Create Standalone Application" radio button *is* given focus. It is not
good to actually select it - the user should do that. (Among other reasons, when
you select it for the first time you get a different dialog.)