This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 64500 - License is disregarded when building nbm
Summary: License is disregarded when building nbm
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2005-09-15 21:31 UTC by Petr Jiricka
Modified: 2005-11-29 13:28 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2005-09-15 21:31:24 UTC 
I tried to build an nbm for my module and I couldn't get it to include the
license I need. To reproduce:

1. Add the following line to db/derby/nbproject/project.properties:
license.file=../external/derby-10.1.1.0-license.txt
2. Run ant nbm in the db/derby directory
=> File Info/info.xml inside the created nbm file does not contain my license

I investigated a bit, and found out that during the build, file
nbbuild/default-properties.xml is run first, which sets incorrect value of
property license.file on line 19. Only after that, target basic-init in
nbbuild/templates/common.xml is run, but line 24 (which should read my value of
the license.file property) has no effect since license.file is already set.
Comment 1 Jesse Glick 2005-09-15 21:55:03 UTC 
license.file is not supported for netbeans.org modules. You will need to
override the nbm target. You would need to do this anyway to include the normal
combination of the SPL for the module itself plus an external license for the
bundled binary. Look at any other nb.org module with a bundled third-party file
to see how it is done.
Comment 2 Petr Jiricka 2005-09-15 22:14:22 UTC 
Thanks for the hint. Does this also mean that the behavior of the UI for setting
the license.file property in the module properties dialog should be different
for netbeans.org modules?
Comment 3 Martin Krauskopf 2005-09-15 22:27:16 UTC 
May be I could disable it, or hide at all, for NB.org modules? Shouldn't be a
big problem.
Comment 4 Jesse Glick 2005-09-15 22:49:23 UTC 
Yes please disable for nb.org modules. I just changed the spec.
Comment 5 Martin Krauskopf 2005-09-15 23:18:19 UTC 
Off-topic. In cases like this should I disable also JLabel or just "live"
components like JButton, JTextField, .... The former(disabling also JLabels)
seems to be more natural to me.

Fixed (+ few minor UI tweaks)

Checking in ui/customizer/CustomizerPackaging.form; 1.2 --> 1.3
Checking in ui/customizer/CustomizerPackaging.java; 1.11 --> 1.12
Checking in ui/customizer/SingleModuleProperties.java; 1.26 --> 1.27
Comment 6 Jesse Glick 2005-09-15 23:30:30 UTC 
I guess you should also disable JLabel's, for A11Y purposes. I don't know of any
guidelines on this.
Comment 7 pzajac 2005-11-29 13:28:46 UTC 
verified