This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 64474 - JSP "Go To" does not work
Summary: JSP "Go To" does not work
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP (show other bugs)
Version: 5.x
Hardware: PC Windows XP
: P3 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2005-09-15 17:12 UTC by clever
Modified: 2006-02-17 11:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description clever 2005-09-15 17:12:41 UTC
Hello,

Using build 200509081355.

The popup "Go To.." menu item does not work.  Instead of getting a list of
locations to "go to", I see a very small square; reminescent of an empty list of
items.
No exceptions are thrown, and nothing appears in the IDE log file.
Comment 1 Petr Pisl 2005-09-15 17:59:50 UTC
Thanks for catching this. There shouldn't be this action. So we need to remove
the Go to item from the jsp editor context menu.
Comment 2 clever 2005-09-15 18:17:35 UTC
This is odd.  Why is this being removed?  I saw recently another RFE that even
states that the feature now exists.  This is a real nice feature, and I'm going
to miss not having it for JSP editing :(

On another note, why could the parts of the Java core simply be "plugged" into
JSP editing (with some mods of course), so that complete functionality reuse can
be achieved? (ie. reduce overall codebase, plus, once a feature is added to the
Java core, it's immediately available to JSP editing)  Seems like most, if not
all, java editing functionality should exist for 'scriptlet' editing. (after
all, it is pure java that winds up in the servlet -- with a few restrictions)
Comment 3 clever 2005-09-15 18:27:21 UTC
In fact, after working with some JSP code, I'm really getting curious as to why
this feature will be removed.  It seems that if I can get popup JavaDoc for my
method that the editor knows exactly WHERE the code is.  How hard could it be to
wire that location information into the "Go To..." menu? At least "Go to source"
Comment 4 clever 2005-09-15 18:33:26 UTC
FYI:
Bug #61642 details the feature. And states that it works. Perhaps some
confusion? I'll gladly test. :0)

Cheers!
-Sean
Comment 5 Jiri Kovalsky 2005-09-15 18:49:01 UTC
Yes, this is actually a regression of #61642. Please do not remove the
functionality. Marku can you please take a look why this stopped working ?
Comment 6 Petr Pisl 2005-09-16 09:02:37 UTC
I'm sorry. I missed that this is regression.
Comment 7 Jiri Kovalsky 2005-10-19 14:19:18 UTC
Given this is a regression, please fix it in NetBeans 5.0.
Comment 8 Marek Fukala 2005-10-21 17:10:48 UTC
The regression is caused by Martin's fix of Issue #60928 (Allow inserting custom
menu items into the Go To submenu). The menu items are not longer generated by a
special action in editor kit but are loaded according to layer declaration.

I have fixed this issue. However the behaviour is still not as it used to be.
When I used the non-layer method of putting popup menu subitems (goto
declaration, source etc...) into the "Goto" popup menu item I made it
context-aware. So the Goto Declaration, Goto Super Implementation and Goto
Source actions were enabled only when the popup menu was invoked within a java
scriptlet. Now they are enabled everywhere in the JSP. I do not see any simple
way how to workaround this now. Martine, do you have an idea? I would appreciate
your opinion on this. Thanks.

Checking in
web/jspsyntax/src/org/netbeans/modules/web/core/syntax/DefaultKeyBindings.xml;
/cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/DefaultKeyBindings.xml,v
 <--  DefaultKeyBindings.xml
new revision: 1.3; previous revision: 1.2
done
Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/layer.xml;
/cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/layer.xml,v  <-- 
layer.xml
new revision: 1.17; previous revision: 1.16
done
Comment 9 Martin Roskanin 2005-10-31 12:03:59 UTC
Did you try to create your own goto declaration, goto source... actions?
You can create a method getDefault that will find an action via name using
similar way like this:

Action a = Utilities.getKit(target).getActionByName(actionName);

and then the method will create a context aware instance and return it.
You can call such getDefault method from layer using methodvalue attr.
Comment 10 Dan Kolar 2006-02-17 11:37:25 UTC
verified