This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 64210 - Move specification of defaultActions for PropertiesDataLoader to layer.xml
Summary: Move specification of defaultActions for PropertiesDataLoader to layer.xml
Status: VERIFIED INVALID
Alias: None
Product: utilities
Classification: Unclassified
Component: Properties (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marian Petras
URL:
Keywords:
Depends on:
Blocks: 64153
  Show dependency tree
 
Reported: 2005-09-13 09:58 UTC by pzajac
Modified: 2005-10-31 19:34 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pzajac 2005-09-13 09:58:22 UTC
Please do it for 
org.netbeans.modules.properties.PropertiesDataLoader

For details see issue #64153
Comment 1 Marian Petras 2005-09-14 14:43:54 UTC
This was done three months ago - see issue #59449.
Comment 2 pzajac 2005-09-14 15:37:13 UTC
Aha, the 
defaultActions return null.

Is it necessary?
Comment 3 Marian Petras 2005-09-15 10:58:45 UTC
Yes, it is necessary because the API documentation does not specify the default
value. The default value can be changed at any time (without breaking API
compatibility) and I want it to be always null.

Javadoc description of the method is at
http://www.netbeans.org/download/dev/javadoc/LoadersAPI/org/openide/loaders/DataLoader.html#defaultActions()
Comment 4 Jesse Glick 2005-09-23 16:55:14 UTC
Please cease to override defaultActions(). It does not matter what it returns if
you are specifying a layer context, since it will not be called.
Comment 5 Marian Petras 2005-10-13 15:03:36 UTC
OK, I will do it. But bear in mind that it is not clear from the API description
what is called first - defaultActions() or actionsContext(). Should I file an
issue for this?
Comment 6 Jesse Glick 2005-10-27 21:28:12 UTC
Go ahead and file a docs bug if you think it is needed.
Comment 7 Marian Petras 2005-10-28 07:16:05 UTC
Filed: http://www.netbeans.org/issues/show_bug.cgi?id=67712
Comment 8 Jaroslav Tulach 2005-10-31 08:22:19 UTC
What is the problem with overriding method that is not called? Functionality 
in org.openide.loaders shall not be affected by doing that... 
Comment 9 Marian Petras 2005-10-31 09:37:43 UTC
Since my proposals of the API change were not accepted, I will keep the method.
Comment 10 Jesse Glick 2005-10-31 19:23:12 UTC
"Since my proposals of the API change were not accepted, I will keep the
method." - huh? The new Javadoc says that the old methods is not needed any
more. Delete it, please, so that we do not have bogus matches in Find Usages etc.
Comment 11 Marian Petras 2005-10-31 19:34:29 UTC
Strictly speaking, neither the previous nor the new Javadoc description contains
any obligation regarding the default value or use of the method. Compare it with
description of actionsContext():

   The default implementation returns null to indicate that no
   layer reading should be used (use {@link #defaultActions} instead).