This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 62460 - "More" button points to nbbuild.netbeans.org
Summary: "More" button points to nbbuild.netbeans.org
Status: VERIFIED FIXED
Alias: None
Product: updatecenters
Classification: Unclassified
Component: AU Masters (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Michal Zlamal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-17 10:23 UTC by Jaromir Uhrik
Modified: 2005-09-19 15:33 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaromir Uhrik 2005-08-17 10:23:10 UTC 
[#200508161800]
1.Go to Tools | NetBeans Update
2.Connect to the Development Update Center
3.In panel #2 of the wizard select any module and push More button
4.The browser appears and points to nbbuild.netbeans.org instead of the module's
page
Comment 1 Jiri Rechtacek 2005-08-19 10:00:48 UTC 
No problem in AutoUpdate client, the address http://nbbuild.netbeans.org is
generated by build system.

Robert, could you consider if any other address should generated or not? Thanks
Comment 2 Jesse Glick 2005-08-19 22:29:18 UTC 
My suspicion: when you run

ant -f foo/bar/build.xml nbm

then homepage in info.xml is set correctly. But perhaps
nbbuild/build.xml#build-nbms calls every module with nbm.domain set to
'nbbuild', due to inheriting this property from the master script?
Comment 3 rbalada 2005-08-23 22:24:47 UTC 
I suspect code on lines 609-621 of
nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java (lines which I authored) cause
this bug in present buildsystem metadata flow.
I would also consider promoting the "else block" of that code to BuildException
or at least warning msg at MSG_INFO level. It's now simple debug msg.
Comment 4 Jesse Glick 2005-09-08 15:14:41 UTC 
This is a noticeable problem.
Comment 5 Patrick Keegan 2005-09-08 15:39:18 UTC 
I would suggest disabling the button if no link exists. The module home pages
are not necessarily useful.
Comment 6 Jesse Glick 2005-09-08 15:53:55 UTC 
The problem is that the link always *does* exist and it is always wrong.

Patrick - if you want to file an RFE for the autoupdate module to conditionally
enable the button, please do so separately as it is independent of this build
system bug. (The homepage attr is optional in the DTD, though I am not sure if
the standard module build harness actually lets you omit it.)
Comment 7 Michal Zlamal 2005-09-15 15:10:59 UTC 
The problem is in ParseProjectXML.java, which sets the domain nbm.domain 
property.
Comment 8 Michal Zlamal 2005-09-15 16:57:56 UTC 
There was getProject().getProperty("basedir") instead of getProject().
getBasedir()

Checking in antsrc/org/netbeans/nbbuild/ParseProjectXml.java;
/cvs/nbbuild/antsrc/org/netbeans/nbbuild/ParseProjectXml.java,v  <--  
ParseProjectXml.java
new revision: 1.31; previous revision: 1.30
done
Comment 9 Jaromir Uhrik 2005-09-19 15:33:14 UTC 
Verified in dev build #200509181800. I just checked out the jellytools module
link and it works fine.