This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Your patch to ModuleListParser seems to have broken the scenario of building to a separate dest dir. If you run ant -f nbbuild/build.xml -Dnetbeans.dest.dir=/somewhere/else build-platform it breaks with a NPE, because scanStandaloneSource is being called from a ModuleListParser constructor called from InsertModuleAllTargets, so properties["project"] == null (which is fine). Changing the if-clause to if (scanNetBeansSources || properties.get("project") == null) ... helps for a while, but it breaks later, because individual modules get scanned using scanStandaloneSource later, and they are treated as standalone modules... so Entry.jar is set to e.g. openide/explorer/build/cluster/modules/org-openide-explorer.jar, which is nonsense. Reverting your patches - most simply, setting scanNetBeansSources = true unconditionally - makes the build work. I would recommend the check for netbeans.dest.dir inside nb_all be removed, and the default behavior be what it was originally. The test builder machine could pass some special Ant property which would produce your behavior.
Well, it is not nice. Ideal would be to detect if netbeans.dest.dir contains built IDE or not. But I think there is no such condition which can be checked. I think we can use what Jesse suggested at the end - check whether xtest.home property is set. If yes it is called from test (scan binaries), otherwise scan sources. Do you think it is acceptable?
Created attachment 23735 [details] Suggested patch of ModuleListParser
I think that makes sense.
Fixed as suggested. /cvs/nbbuild/antsrc/org/netbeans/nbbuild/ModuleListParser.java,v <-- ModuleListParser.java new revision: 1.21; previous revision: 1.20