This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 61368 - Do not subclass CookieAction for permanently enabled actions
Summary: Do not subclass CookieAction for permanently enabled actions
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Rob Englander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-25 16:33 UTC by _ rkubacki
Modified: 2009-02-19 20:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2005-07-25 16:33:30 UTC 
DB explorer contains many actions that are subclasses of CookieAction thought
they actually should not be. The enable() method is overriden to return always
true or performs some computation but never calls super.enable(). It means there
is no reason to use CookieAction and it only creates more complex inheritance chain.
Comment 1 Andrei Badea 2005-10-10 08:41:54 UTC 
Right, there doesn't seem to be a need for the actions to extend CookieAction. I
will replace CA with NodeAction.
Comment 2 Petr Blaha 2006-03-13 13:32:14 UTC 
TM 5.0 -> TBD
Comment 3 Andrei Badea 2007-02-15 17:22:16 UTC 
Will try for 6.0.
Comment 4 Rob Englander 2009-01-16 15:59:23 UTC 
This was handled by the db explorer rewrite.
Comment 5 Roman Mostyka 2009-01-16 16:18:49 UTC 
Verified.