This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 61170 - Bad position of Platform Name field in Add Platform dialog
Summary: Bad position of Platform Name field in Add Platform dialog
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2005-07-20 13:29 UTC by pzajac
Modified: 2005-09-05 09:51 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
patch1 (7.04 KB, text/plain)
2005-07-20 14:43 UTC, Martin Krauskopf 		Details
adjusted spec (4.42 KB, text/plain)
2005-07-21 08:40 UTC, Martin Krauskopf 		Details
adjusted spec - better (4.42 KB, text/plain)
2005-07-21 08:43 UTC, Martin Krauskopf 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pzajac 2005-07-20 13:29:31 UTC 
Currently The platform Name is on right side of file list. It will be better to
place it bellow to file list :
----------------------------------
| file list                      |
---------------------------------
Platform Name : [Netbeans 4.1]
File Name     : [nb41]
File of Type :  [Platform Folder]
Comment 1 pzajac 2005-07-20 13:34:18 UTC 
IMHO the second steps in Add NetBeans Platform wizard is useless. I propose to
change the Platfrom Name JLabel to JTextField.
Comment 2 Martin Krauskopf 2005-07-20 13:56:14 UTC 
I agree. Note that on the windows OS the sitation is even worse since those icon
on the left side of Windows FileChooser.
Comment 3 Martin Krauskopf 2005-07-20 14:43:17 UTC 
Created attachment 23180 [details]
patch1
Comment 4 Martin Krauskopf 2005-07-20 14:45:05 UTC 
I've just tried it with the attached patch and its at least 100% :) better. I
could commit and adjust UI spec if everybody (UI spec author) agree.
Comment 5 Jesse Glick 2005-07-20 20:26:20 UTC 
Not so fast. I intentionally made this wizard look as much as possible like the
corresponding wizard from the Java Platform Manager dialog. If we change it in
one place, we must change it in both. Also consider consistency with the Open
Project dialog and other places where we add controls to a file chooser; to date
we have always used JFileChooser.accessory for such purposes. (The actual
placement of the accessory is up to the L&F.)
Comment 6 Martin Krauskopf 2005-07-21 08:39:24 UTC 
Aha. I see. But there is a *Label* used for a platform name value in your spec.
So after changing it to a textfield everything should be ok. Since the biggest
problem was that flickering during selecting different NB platform.
So did you want to use textfield Jesse. If you did, I'll apply the *following*
patch and fix the customizer (and close this issue).
Comment 7 Martin Krauskopf 2005-07-21 08:40:00 UTC 
Created attachment 23197 [details]
adjusted spec
Comment 8 Martin Krauskopf 2005-07-21 08:43:14 UTC 
Created attachment 23198 [details]
adjusted spec - better
Comment 9 Jesse Glick 2005-07-21 17:12:11 UTC 
Yes, you should be using a noneditable (but enabled) text field for the name
field, not a label.
Comment 10 Jesse Glick 2005-07-21 17:13:40 UTC 
The HTML UI spec is fine. It already specifies:

"Should also display a read-only text field giving the computed display name of
the platform...."

(My notation does not use '[' / ']' around r/o text fields.)
Comment 11 Martin Krauskopf 2005-07-21 21:08:42 UTC 
Fixed as it is specified in the UI spec. Please fill up another issue as an UI
enhancement, Zajo, if you want. Probably in some more general component since it
concerns all such dialogs as wrote by Jesse above.

Checking in ui/platform/PlatformChooserVisualPanel.form; 1.1 --> 1.2
Checking in ui/platform/PlatformChooserVisualPanel.java; 1.4 --> 1.5
Comment 12 pzajac 2005-07-25 12:40:55 UTC 
I looks much better now.