This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Annotation.attach(Annotatable): 639 annotations attached in 9512ms. 308 annotations attached in 3346ms. 148 annotations attached in 541ms. 79 annotations attached in 49ms. 49 annotations attached in 79ms. 36 annotations attached in 164ms. (on 2.4GHzPentium) Probably caused by errorstripe client: at org.netbeans.editor.BasePosition.getOffset(BasePosition.java:41) at org.netbeans.editor.LineElement.getStartOffset(LineElement.java:69) at org.netbeans.lib.editor.util.swing.GapBranchElement.getElementIndex(GapBranchElement.java:92) at org.netbeans.editor.LineRootElement.getElementIndex(LineRootElement.java:254) at org.netbeans.editor.Utilities.getLineOffset(Utilities.java:555) at org.netbeans.modules.editor.NbEditorDocument$AnnotationDescDelegate.getLine(NbEditorDocument.java:351) at org.netbeans.editor.Annotations$LineAnnotations.getLine(Annotations.java:877) at org.netbeans.editor.Annotations.getLineAnnotations(Annotations.java:363) at org.netbeans.editor.Annotations.getActiveAnnotation(Annotations.java:378) at org.netbeans.modules.editor.errorstripe.annotations.AnnotationMarkProvider.getAnnotationsForLineImpl(AnnotationMarkProvider.java:79) at org.netbeans.modules.editor.errorstripe.annotations.AnnotationMarkProvider.createMarks(AnnotationMarkProvider.java:96) at org.netbeans.modules.editor.errorstripe.annotations.AnnotationMarkProvider.changedAll(AnnotationMarkProvider.java:123) - locked <0x4987a458> (a org.netbeans.modules.editor.errorstripe.annotations.AnnotationMarkProvider) at org.netbeans.modules.editor.errorstripe.annotations.AnnotationMarkProvider.changedLine(AnnotationMarkProvider.java:117) at org.netbeans.editor.Annotations.fireChangedLine(Annotations.java:555) Please employ some sort of batching, etc.
The numbers attached by pkuzel look veeery bad.
Without errostripe I'm getting (message comes from CVS support module): #59721 should be reopened: 573 of 729 annotations attached in 705ms. Setting performance limit.
Honzo, will you take a look at this or should this issue be assigned to somebody else? Sorry for bothering but it's a P2.
Honzo, please look at it.
The error stripe has been rewritten and the scalability (of handling annotations in the error stripe) should have been vastly improved.
Petre, could you please remeasure the cases you mentioned at the beginning of this issue with the new errorstripe implementation? It would be nice to have exact comparison to the old numbers.... Thanks.
One more note: if possible, please try to do the measurements with errorstripe module enabled&disabled to see the difference.
Trap is in code. It creates log if slow.
I read in my console the following message to reopen this issue. #59721 should be reopened: 98 of 186 annotations attached in 711ms. Setting performance limit. Most likely triggered by the cvs annotation action.
I did some quick tests with and without the error stripe. With errorstripe, the report was: #59721 should be reopened: 120 of 951 annotations attached in 705ms. Setting performance limit. Without errorstripe, the report was: #59721 should be reopened: 126 of 951 annotations attached in 704ms. Setting performance limit. So it seems to me that the difference caused by the errorstripe is insignificant and the main problem is somewhere else. Someone in the editor please evaluate.
If the errorstripe is not the cause of the problem then I'm reassigning to javacvs client which is the only other client known to me that attaches a big number of anntotations. Please check what's the count of the annotations attached by javacvs and please have in mind that even if you deattach the particular annotation its corresponding DocumentLine instance (to which the annotation is attached) is likely still active and held in PositionRef.Manager in CloneableEditorSupport.
I'll try to profile current annotation framework.
In issue #66470 I have raised friend ErrorStripe SPI request. It addresses core problem causing this issue (offset -> linenum -> Line -> new Annotation ,...).
FIXED Introduced implementation dependecy on ErrorStripe bypassing Annotations API: RCS file: /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkProvider.java,v done Checking in src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkProvider.java; /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkProvider.java,v <-- AnnotationMarkProvider.java initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkInstaller.java,v done Checking in src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkInstaller.java; /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMarkInstaller.java,v <-- AnnotationMarkInstaller.java initial revision: 1.1 done Checking in src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationBar.java; /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationBar.java,v <-- AnnotationBar.java new revision: 1.24; previous revision: 1.23 done RCS file: /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMark.java,v done Checking in src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMark.java; /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationMark.java,v <-- AnnotationMark.java initial revision: 1.1 done Checking in nbproject/project.xml; /shared/data/ccvs/repository/javacvs/cvsmodule/nbproject/project.xml,v <-- project.xml new revision: 1.13; previous revision: 1.12 done Checking in src/org/netbeans/modules/versioning/system/cvss/resources/layer.xml; /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/resources/layer.xml,v <-- layer.xml new revision: 1.15; previous revision: 1.14 done Checking in deps.txt; /shared/data/ccvs/repository/ide/golden/deps.txt,v <-- deps.txt new revision: 1.225; previous revision: 1.224 done
*** Issue 65128 has been marked as a duplicate of this issue. ***
FIXED