In Project view there are
files without CVS statuses consistently visualized (become green on local
modification). Note that respective nodes contain CVS actions.
Expected behaviour: all nodes that somehow represent file(s) must consult
FileSystem.[Html]Status to let it annotate name, htmlName and icon.
Icon is I guess already badged.
File icons are not CVS badged (compare to containers/folders). So users do not
notice actual file status until they inspect Files view or Versioning view.
P3, it's rather visible and users are very sensitive to proper status visualization.
Moreover Important Files (LogicalViev.ImportantFilesNode) container is ackward too.
Because it does correspond to physical folder it must take FileSystem for any
file it contains and ask the FileSystem to annotate its icon, name and htmlName
passing own inital icon, name, htmlName and Set of all contained files.
I have an NBM project (check out from CVS) open right now and the file badging
under Important Files works fine, I don't know what you're talking about. Please
attach a screenshot and build info if you see otherwise.
Will not put any CVS status on the Important Files node itself. It has no
correspondence to any physical structure; it just would not make sense to
New CVS does not annotate single file icons. You can not see any. It annotates
file's htmlName only.
Logical containers should be annotated too. It gets barged once at least one
file in container has conflict or is locally modified.
Created attachment 22165 [details]
I guess you're talking about upcoming changes not yet in the trunk?
Can badge Important Files if you really think it should be. Just sounds odd to
me, because it's not a natural file unit the way a source group is, and it's
showing files which also appear in other places (just in a more convenient
Yes, I mean upcoming changes not yet in the trunk.
Partially implemented for Important Files (firing is not reliable).
Need to be implemented for subnodes.
Martin do you have time for it?
New code, could be interesting. So yes, I will :)
Implemented for subnodes.
Checking in ui/ModuleLogicalView.java; 1.11 --> 1.12
Petre, what did you mean by: "Partially implemented for Important Files"? Are
you working on this? "Important Files" icon is still not badget.
Ok. If nothing closing. All seems to work now including Important Files.
XML Layer does not - issue #68240.
badged, colored. Verified.