This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 58035 - Deadlock by invoking "CVS | Check out"
Summary: Deadlock by invoking "CVS | Check out"
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Dialogs&Wizards (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: RANDOM
Depends on:
Blocks:
 
Reported: 2005-04-19 13:39 UTC by Peter Pis
Modified: 2008-12-22 22:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
thread dump (20.27 KB, text/plain)
2005-04-19 13:40 UTC, Peter Pis 		Details
Jirka's fix (2.59 KB, patch)
2005-05-03 16:19 UTC, _ pkuzel 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2005-04-19 13:39:17 UTC 
Product Version       = NetBeans IDE Dev (Build 050415)
Operating System      = Windows XP version 5.1 running on x86
Java; VM; Vendor      = 1.5.0_03; Java HotSpot(TM) Client VM 1.5.0_03-b05; Sun
Microsystems Inc.
Java Home             = d:\Java\jdk1.5.0_03\jre

After some work with cvslite, I invoked "CVS | Check out" and netbeans had frozen.
Comment 1 Peter Pis 2005-04-19 13:40:07 UTC 
Created attachment 21723 [details]
thread dump
Comment 2 _ pkuzel 2005-04-20 10:57:37 UTC 
Should not 
        - locked <0x02ada7d0> (a org.openide.WizardDescriptor)
        at
org.openide.WizardDescriptor$Listener.stateChanged(WizardDescriptor.java:1276)

repost to AWT?
Comment 3 _ pkuzel 2005-04-20 10:59:05 UTC 
I could HACK by invokeLater in my code but I think that that's wizard issue.
Comment 4 Jiri Rechtacek 2005-04-20 12:17:39 UTC 
Please, call WD.updateState() from AWT. I think it's should be called from event
queue only. I'll add an assertion in WD on this place and will document in
javadoc. Thanks
Comment 5 _ pkuzel 2005-04-20 13:21:56 UTC 
Hey Jirka, that's your code that react to my change events! 

Well, I fire change events from AWT. It's HACK. I can fire from arbitrary thread
AFAIK.

Checking in
src/org/netbeans/modules/versioning/system/cvss/ui/wizards/CheckoutWizard.java;
/cvs/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/wizards/Attic/CheckoutWizard.java,v
 <--  CheckoutWizard.java
new revision: 1.1.2.23; previous revision: 1.1.2.22
done
Comment 6 _ pkuzel 2005-05-03 16:18:06 UTC 
Jirka has fix for wizard framework.
Comment 7 _ pkuzel 2005-05-03 16:19:58 UTC 
Created attachment 21962 [details]
Jirka's fix
Comment 8 Jiri Rechtacek 2005-05-04 15:07:11 UTC 
Patch is ready to integration, only needs to avoid any regression.
Comment 9 Jiri Rechtacek 2005-05-11 13:57:23 UTC 
Checking in openide/dialogs/src/org/openide/WizardDescriptor.java;
/cvs/openide/dialogs/src/org/openide/WizardDescriptor.java,v  <-- 
WizardDescriptor.java
new revision: 1.2; previous revision: 1.1
done
Comment 10 Peter Pis 2005-05-16 10:02:19 UTC 
I cannot reproduce it anymore. Verified.