This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57835 - All watches are reevaluated when new watch is added
Summary: All watches are reevaluated when new watch is added
Status: VERIFIED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: PC Windows XP
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: PERFORMANCE
Depends on: 60499
Blocks:
  Show dependency tree
 
Reported: 2005-04-13 14:17 UTC by _ lcincura
Modified: 2005-10-12 13:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ lcincura 2005-04-13 14:17:53 UTC 
NetBeans IDE 4.2 [200504101800] on jdk 1.5.0_03

When new watch is added, all existing watches are evaluated again. This can lead
to performance problems (J2ME debugging or watches, that are evaluated long time)
Comment 1 Roman Ondruska 2005-04-14 16:39:43 UTC 
I can reproduce it.
Comment 2 Martin Entlicher 2005-06-24 17:35:45 UTC 
Also when a watch is deleted, the others are refreshed.
This is because ModelEvent.TreeChanged is fired in WatchesTreeModel, which in
turn calls rootNode.setObject (model.getRoot ()); in TreeModelRoot.

We need an event like NodeChildrenChanged, which would refresh only the list of
children and not node's properties.
Comment 3 Martin Entlicher 2005-06-24 18:26:07 UTC 
More fine-grained firing is necessary - depends on issue #60499.
Comment 4 Martin Entlicher 2005-07-13 15:25:56 UTC 
Fixed using a workaround for more fine-grained firing. Issue #60499 will address
the API change that allows to fix it in a better way.

/cvs/debuggercore/viewmodel/src/org/netbeans/modules/viewmodel/TreeModelNode.java,v
 <--  TreeModelNode.java
new revision: 1.36; previous revision: 1.35

/cvs/debuggercore/viewmodel/src/org/netbeans/modules/viewmodel/TreeModelRoot.java,v
 <--  TreeModelRoot.java
new revision: 1.12; previous revision: 1.11

/cvs/debuggercore/src/org/netbeans/modules/debugger/ui/models/WatchesTreeModel.java,v
 <--  WatchesTreeModel.java
new revision: 1.5; previous revision: 1.4

/cvs/debuggerjpda/src/org/netbeans/modules/debugger/jpda/models/WatchesModel.java,v
 <--  WatchesModel.java
new revision: 1.18; previous revision: 1.17
Comment 5 _ lcincura 2005-10-12 13:29:23 UTC 
Verified on build 200510111800