This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Development build #200504111930 of NetBeans 4.1 Windows XP, JDK 1.5.0_03 build #06 Description: ============ Functionality of "PVCS|Add All" command is seriously broken. It is now impossible to add complex directory structure e.g. project into PVCS archive because the recursive Add command is not even executed. This is a severe regression and it must be definetely fixed into 4.1 FCS. Steps to reproduce: =================== 1. Register already existing PVCS working directory in "Versioning Manager". 2. Create new sample Java application project in that working directory. 3. Switch to "Files" view and invoke "PVCS|Add All" on the project root node. 4. Confirm accepting simple mode by clicking "Add All". 5. Type "abcd" into "Workfile Description:" and "Change Description" fields. 6. Check "Add all subdirectories" option and push "OK" button. 7. Nothing is added. Switch to "Versioning" view to see that there was new <project>_FilesNotAdded##### directory created. All nodes remain [Local]. Workaround: =========== To workaround it, one has to do things manually i.e. use "PVCS|Create Project" action for all packages and "PVCS|Add" for all files inside the project.
Created attachment 21570 [details] Screenshot of commands in Runtime tab.
Created attachment 21571 [details] Screenshot of the structure in Versioning tab.
This error is ugly, but in q-build (Build 200504060831) it works fine.
This bug seems to be caused by improper fix of issue #56047. The synchronization is not made correctly, there can occur a race-condition.
Do you say we will release 4.1 with this defect ?
Moving into vcscore module, the problem is caused by the fact that ADD_DIR is not executed at all due to that race-condition (it's waiting for it's pre-commands although they have already finished).
Fixed in trunk: /cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v <-- UserCommandTask.java new revision: 1.43; previous revision: 1.42
Created attachment 21598 [details] The textual patch that fix this issue.
Bunch of tasks is added in atomic action (in respect to ther threads. It can not hurt anything. REVIEWED
Thanks for the review, the fix is merged into release41 branch: /cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v <-- UserCommandTask.java new revision: 1.42.4.1; previous revision: 1.42
Verified in continuous development build #20050414-1537 of NetBeans 4.1.
Thanks for quick verifying.