This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57704 - [41cat] Renaming of favorites has no effect
Summary: [41cat] Renaming of favorites has no effect
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Favorites (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: mslama
URL:
Keywords:
: 60528 64887 (view as bug list)
Depends on: 113859
Blocks: 57702 108958
  Show dependency tree
 
Reported: 2005-04-09 23:15 UTC by ulfzibis
Modified: 2008-12-22 11:31 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ulfzibis 2005-04-09 23:15:48 UTC 
When I select 'Rename' via right-mouse-button menu on an item in favorites
window and change the name, nothing happens.
Comment 1 ulfzibis 2005-04-11 15:30:43 UTC 
This issue was reported in NetCAT 4.1 program.
Comment 2 Marian Mirilovic 2005-04-15 13:55:55 UTC 
You are right, it doesn't work when you add the file to the favorites and try to
rename the same file as a link in Favorites...
Comment 3 Tomas Danek 2005-07-21 11:15:17 UTC 
Dupl. with issue 60528:
comment:
------------------------------
When i perform Rename on some node in favorites, only its property Name is
changed, but in favorites window i still see the old name. So in the name of
node should be displayed its property Name (not Original name), otherwise action
rename is useless.
Comment 4 Tomas Danek 2005-07-21 11:18:13 UTC 
*** Issue 60528 has been marked as a duplicate of this issue. ***
Comment 5 Tomas Danek 2005-09-22 11:52:36 UTC 
*** Issue 64887 has been marked as a duplicate of this issue. ***
Comment 6 Marian Mirilovic 2005-09-22 14:41:40 UTC 
Marek, 
do you plan to fix this for NB 5.0 ?
Comment 7 Marian Mirilovic 2006-01-03 10:54:06 UTC 
Too late for NB5.0, please reevaluate.
Comment 8 mslama 2007-08-27 15:16:21 UTC 
It is by design. I can change it. Change should not break anything else. Current impl takes node display name from
original file not from DataShadow itself but Rename action renames DataShadow. I changed this to take name of
DataShadow. The rest of label ie. path stays the same.

Modified:
/cvs/core/favorites/src/org/netbeans/modules/favorites/Favorites.java,v  <--  Favorites.java
new revision: 1.27; previous revision: 1.26
Comment 9 mslama 2007-08-27 15:32:29 UTC 
Lowering priority. Unfortunately it does not work correctly. I filed separate issue to handle problem. See #113859. It
works correctly only on first rename. Second rename is not handled correctly.
Comment 10 ulfzibis 2007-08-27 18:44:44 UTC 
As I understand right, it doesn't still work.
... so I reopen this issue!
Comment 11 mslama 2007-08-28 09:11:02 UTC 
This happens only when you rename Home link predefined in layer. If you create 'normal' favorites link renaming works
fine even repeatedly.
Comment 12 mslama 2007-08-28 11:18:40 UTC 
Workaround is simple: Do not rename predefined link to Home in Favorites. Original problem is solved. New issue is filed
so IMO this issue can be closed as fixed as Favorites link can be renamed now and only in one special case this has
undesirable effect.
Comment 13 ulfzibis 2007-10-26 02:11:36 UTC 
Works fine in NB 6.0 Beta 2.