This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57198 - 'Send JMS message' action doesn't create all entries in DDs
Summary: 'Send JMS message' action doesn't create all entries in DDs
Status: CLOSED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords:
Depends on: 57104
Blocks:
  Show dependency tree
 
Reported: 2005-03-30 13:53 UTC by Petr Blaha
Modified: 2006-03-24 12:54 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Blaha 2005-03-30 13:53:12 UTC 
[Build 20050329]
Steps:
1) create J2EE application
2) add MDB to EJB module
3) create new servlet and invoke 'Send JMS message', the lookup method and
message-destination-ref are generated. However, resource-ref element for Factory
is missing in web.xml and sun-web.xml also. User can't send message without
changing DDs. This feature was working in NB 4.1 EA2.
I guess that this doesn't work in EJB also.
Comment 1 Martin Adamek 2005-03-30 15:52:10 UTC 
Plugin problem?
Comment 2 _ ludo 2005-03-30 16:07:35 UTC 
not sure we changed code there, but we'll investigate asap.
Related one is
http://www.netbeans.org/issues/show_bug.cgi?id=57188
I think...

Event issue or bad content for the ejb-jar.xml ?
Comment 3 _ ludo 2005-03-30 16:13:23 UTC 
also p2 57187 seems to be related no?
Comment 4 _ ludo 2005-03-30 17:37:53 UTC 
I see the message-destination-ref in web.xml, but nothing else...

So this is a real bug. Might not be related to the 2 other mentioned bugs..
Comment 5 _ ludo 2005-03-30 19:29:15 UTC 
seems to be a j2eeserver bug not calling our impl for ensureResourceDefined()
sometimes... Not sure why, but not a plugin bug for sure...
Comment 6 Rajeshwar Patil 2005-03-30 20:33:28 UTC 
I am not able to reproduce this build 03242004.  
I am able to reproduce this in the latest trunk build. I am not seeing any issue
with the resource creation. Only problem as reported is the missing
<resource-ref> entry in both the web.xml & sun-web.xml.  Since web.xml entry is
not created, its not getting propagated to the sun-web.xml. Definitely its not
plugin issue.
Comment 7 Martin Adamek 2005-03-31 07:54:31 UTC 
No code is called to create resource-ref entries for both - EJB and Web projects.
Comment 8 Martin Adamek 2005-03-31 11:05:16 UTC 
Problem has 2 parts: EJB and Web. Maybe we should split this into 2 separate issues?

For EJB, adding of resource reference was never called. It is fixed in
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/EnterpriseReferenceContainerImpl.java,v
 <--  EnterpriseReferenceContainerImpl.java; new revision: 1.11; previous
revision: 1.10
Now entry in ejb-jar.xml is created, but not in sun-ejb-jar.xml (j2eeserver or
plugin bug?). Stepane, can you take a look at this?

For Web, code looks fine (just probably should be changed to use WebApp instead
of BaseBean), but nothing is written to web.xml. Reassigning to Milan.
Comment 9 Martin Adamek 2005-03-31 11:34:17 UTC 
OK, correction: for EJB is now everything OK, for both - Call DB and Send JMS
actions, resource-ref entries are created in ejb-jar.xml and also in
sun-ejb-jar.xml. Only problem is now Web project.
Comment 10 Milan Kuchtiak 2005-03-31 17:09:39 UTC 
Depends also on issue 57104.
Comment 11 Milan Kuchtiak 2005-04-02 08:33:00 UTC 
57104 fix helped.
I've changed the way how deployment descriptor changes are implemented.
See :
http://web.netbeans.org/source/browse/web/project/src/org/netbeans/modules/web/project/WebContainerImpl.java?r1=1.11&r2=1.12
Comment 12 Milan Kuchtiak 2005-04-02 08:33:25 UTC 
See comments above.
Comment 13 Petr Blaha 2005-11-04 12:26:08 UTC 
[build 20051103]