This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57094 - CVS: view branches, cannot select Revision B
Summary: CVS: view branches, cannot select Revision B
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: Macintosh Mac OS X
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2005-03-29 09:22 UTC by Pavel Rehak
Modified: 2006-03-24 12:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
NPE (1.83 KB, text/plain)
2005-03-29 09:23 UTC, Pavel Rehak 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Rehak 2005-03-29 09:22:39 UTC 
Product Version       = NetBeans IDE Dev (Build 200503281924)
  Operating System      = Mac OS X version 10.3.8 running on ppc
  Java; VM; Vendor      = 1.4.2_05; Java HotSpot(TM) Client VM 1.4.2-38; Apple Computer, Inc.
-----
Since original Apple Mac HW mouse have just one button i can't use right/left mouse
click in "CVS Branches window"
(CVS | Branching and Tagging | View Branches on file with branch created)
and usual "right click simulation" (apple key + mouse click) doesn't work here :-(
(should be same way as invoking context menu).

By the way if only one revision  A is selected and no revision B is selected ->
NPE is thrown.
Comment 1 Pavel Rehak 2005-03-29 09:23:19 UTC 
Created attachment 21174 [details]
NPE
Comment 2 Martin Entlicher 2005-03-29 12:43:29 UTC 
The NPE should not occur, I've reproduced it and will try to fix it.

I do not know how to catch the apple key + mouse click, this would have to be
explored...
Comment 3 Martin Entlicher 2005-03-29 13:18:27 UTC 
The NPE is thrown even when both revisions are selected. This looks like a
regression.
Comment 4 Martin Entlicher 2005-03-29 14:11:26 UTC 
Fixed in trunk:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsBranches.java,v
 <--  CvsBranches.java
new revision: 1.3; previous revision: 1.2

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsBranchFrame.java,v
 <--  CvsBranchFrame.java
new revision: 1.8; previous revision: 1.7
Comment 5 Martin Entlicher 2005-03-29 14:12:30 UTC 
I've added an extra check to the mouse listener (for isMetaDown()), this will
hopefully solve the problem on Mac.
Comment 6 Pavel Rehak 2005-04-12 10:58:37 UTC 
Verified with build 200504101930.
(note: its possible to select revisions on MAC now - good work :-)