This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 5620 - [nb33][indentation]After Reformat code action all bookmarks and breakpoints are moved to first line of the file.
Summary: [nb33][indentation]After Reformat code action all bookmarks and breakpoints a...
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P2 major with 3 votes (vote)
Assignee: Miloslav Metelka
URL:
Keywords:
: 6835 6836 11994 13161 19050 (view as bug list)
Depends on:
Blocks:
 
Reported: 2000-02-03 00:23 UTC by Petr Slegr
Modified: 2007-11-05 13:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2000-08-01 07:30:59 UTC 
*** Bug 7206 has been marked as a duplicate of this bug. ***
Comment 1 Jan Lahoda 2000-08-01 07:32:59 UTC 
Changing severity to major, because this means big loss of function.
Comment 2 Jan Lahoda 2001-01-24 15:33:59 UTC 
Only changed version to Development.
Comment 3 Jan Chalupa 2001-03-12 10:37:04 UTC 
Version: 'Dev' -> 3.2
Comment 4 Jan Chalupa 2001-05-05 21:55:57 UTC 
Target milestone -> 3.3
Comment 5 David Konecny 2001-06-19 08:57:08 UTC 
This issue will be solved by Netbeans 3.3 by Annotation API
Comment 6 David Konecny 2001-06-19 16:20:42 UTC 
*** Issue 6835 has been marked as a duplicate of this issue. ***
Comment 7 David Konecny 2001-06-19 16:21:17 UTC 
*** Issue 6836 has been marked as a duplicate of this issue. ***
Comment 8 David Konecny 2001-06-19 16:23:06 UTC 
Issue 6835 and issue 6836 are useful test cases.
Comment 9 David Konecny 2001-06-25 07:54:05 UTC 
*** Issue 13161 has been marked as a duplicate of this issue. ***
Comment 10 Jan Lahoda 2001-09-04 15:09:47 UTC 
Regarding to Issue #11994, this may lead in source corruption
(misplaced import statement).
Comment 11 Jan Lahoda 2001-09-04 15:10:31 UTC 
*** Issue 11994 has been marked as a duplicate of this issue. ***
Comment 12 Miloslav Metelka 2001-11-21 18:16:14 UTC 
There are several things to mention:
1) We are unable to fix this bug completely for any generic
indentation engine without changes in indent engine API. Currently the
indent engine gets the text only (without further attributes) and
produces formatted text. Once the original text is formatted (by the
generic indent engine) the editor is no longer able to map the marks
(including bookmarks/breakpoints) from the old text to the new
(formatted) text.

2) We can fix this bug for all editor-generated formatters (indent
engines) by using new formatter design, that we will introduce in 3.4.
The new formatter will reformat the document by directly modifying the
document at the places where it's necessary. It will be available in
3.4 once the lexer module will be ready.
3) We will still not be able to fix loosing of bookmarks/breakpoints
made by form editor (and some wizards too) that regenerates the whole
(guarded) sections from some internal representation. These tools need
to modify their behavior to only make diffs instead of regenerating
the whole (guarded) sections.
Changing target milestone to 3.4.
Comment 13 Jan Chalupa 2001-11-27 12:27:16 UTC 
Target milestone -> 3.3.1.
Comment 14 Miloslav Metelka 2001-12-04 13:11:13 UTC 
Fixed in main trunk, going to fix in release33. I need to fill in an
additional issue for java module. Then I'll close the bug.

Checking in libsrc/org/netbeans/editor/ActionFactory.java;
/cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v  <-- 
ActionFactory.java
new revision: 1.31; previous revision: 1.30
done
Processing log script arguments...
More commits to come...
Checking in libsrc/org/netbeans/editor/ext/ExtFormatter.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/ExtFormatter.java,v  <-- 
ExtFormatter.java
new revision: 1.18; previous revision: 1.17
done
Checking in libsrc/org/netbeans/editor/ext/FormatWriter.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/FormatWriter.java,v  <-- 
FormatWriter.java
new revision: 1.28; previous revision: 1.27
Comment 15 Miloslav Metelka 2001-12-05 13:29:44 UTC 
I have entered issue #18350 on the form module regarding the guarded
sections updating.
I'm closing the bug.
Comment 16 David Konecny 2002-01-02 10:03:34 UTC 
*** Issue 18925 has been marked as a duplicate of this issue. ***
Comment 17 Jan Lahoda 2002-01-04 16:44:23 UTC 
*** Issue 19050 has been marked as a duplicate of this issue. ***
Comment 18 ehucka 2002-10-16 09:50:28 UTC 
Verified in build 200210160100
Comment 19 Quality Engineering 2003-06-30 18:10:19 UTC 
Resolved for 3.3.x or earlier, no new info since then -> closing.