This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56085 - Versioning Manager prohibits CVS ext setups with valid CVS clients
Summary: Versioning Manager prohibits CVS ext setups with valid CVS clients
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Windows XP
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-09 20:13 UTC by manawiz
Modified: 2006-03-24 13:17 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description manawiz 2005-03-09 20:13:48 UTC
Using Versioning Manager, add a new CVS profile of type ext.  Enter the
parameters for working directory, cvs server, repository path, user, etc.,
progressing down the fields in the dialog in order.  Then when you reach the
external client, point to a valid external cvs client.  An error appears saying
this is an invalid client, and the Versioning Manager disables the Finish button
so it is impossible to save the settings or the create the profile.  I tried
with both C:\Program Files\CVS\cvs.exe and C:\cygwin\cvs.exe, both of which are
valid cvs clients (the one in Program Files is the latest stable release from
cvshome).  I eventually created a profile by deleting the Hidden settings for
vcs in the user dir (along with var/cache), and trying every permutation of
field entry orders.  This took hours to find!  One of them eventually worked,
which I can't even reproduce for anybody else.  Even then I could get it to
accept the cygwin client, but not the cvshome client.  After creating the
profile with the cygwin client, I could immediately Edit the profile and change
it to the cvshome client, which works perfectly fine in Netbeans for all cvs
operations!

So, there is a bug in the validation of the external cvs client field in the Add
dialog of Versioning Manager that prohibits creation of cvs connections, render
the vcs completely unusable.

Also, there are Versioning settings that are not in var/cache and not in the
Hidden vcs settings of userdir.  It somehow remembers old settings, which kept
getting in my way.  Where else does it store settings and how can I delete them
when they are messed up.  Specifically, I cannot delete the settings that appear
when I pick a Working Directory that it has seen before.  It then autofills old
settings.

As a suggestion, since Netbeans caching errors are a frequent source of problems
for users, it would be great if ALL such settings were in var/cache so that we
could easily delete them when they are messed.
Comment 1 Martin Entlicher 2005-03-10 11:37:26 UTC
The cvshome client should work fine, it was tested with that. I'm going to look
at it...
Comment 2 Martin Entlicher 2005-03-10 11:44:42 UTC
Right. I've reproduced it. Working on a fix...
Comment 3 Martin Entlicher 2005-03-10 12:17:36 UTC
The fix is trivial. We were waiting for the process *before* we started to read
from the output stream. This led to deadlock. But apparently there is a
different between CVS 1.11.17 and 1.11.19 in the way it produces output.

Anyway, it's fixed now:
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/Validators.java,v
 <--  Validators.java
new revision: 1.7; previous revision: 1.6

This should be a Q-build stopper IMHO, it's quite serious bug.
Comment 4 Peter Pis 2005-03-11 12:26:49 UTC
This is a q-build stopper. There's Q-Build emergency branch "QBE200503101100".
Comment 5 Martin Entlicher 2005-03-14 13:32:59 UTC
The fix is merged into QBE200503101100 branch:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/Validators.java,v
 <--  Validators.java
new revision: 1.6.2.1; previous revision: 1.6

> Specifically, I cannot delete the settings that appear
> when I pick a Working Directory that it has seen before.

This has no setting. It reads the values from CVS/Root file in the working
directory.

var/cache is not a place for IDE settings. There can be only some cached
information that can be retrieved if missing.
Comment 6 Peter Pis 2005-04-04 08:27:20 UTC
Please, can you verify this issue?
Comment 7 manawiz 2005-04-04 17:38:45 UTC
Verified.  This is working properly in the 3/29 qbuild.  Thanks!