This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 54783 - The Add Method dialogs needs adjusting
Summary: The Add Method dialogs needs adjusting
Status: CLOSED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: EJB (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Adamek
URL:
Keywords: UI
Depends on: 55494
Blocks:
  Show dependency tree
 
Reported: 2005-02-09 19:30 UTC by jrojcek
Modified: 2006-03-24 13:10 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Add Method dialog on Windows XP (16.36 KB, image/png)
2005-04-01 13:42 UTC, Jiri Kopsa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2005-02-09 19:30:07 UTC
The Add Method dialogs (Add Business Method, etc.) don't 
follow basic NetBeans layout standards.

There isn't a UI spec for those dialogs.
Comment 1 _ ludo 2005-02-09 21:13:49 UTC
it's almost the same dialog as the add Method dialog for a regular
java class...
Are you saying netbeans pure java support has no ui spec for this
dialog anf the pure java add method dialog is not according to
netbeans standards?

Also, please add a link to the NetBeans layout standards documentation.

Maybe this bug should be moved to java/core IDE category.
Comment 2 jrojcek 2005-02-14 15:09:45 UTC
This is a defect. There are bunch of things that should be corrected:

* usage of titled border should be avoided
* no spacing below the parameters list
* buttons next to the list should be aligned to the top (even if the dialog is resized)
* the parameters list should be aligned to the top if the dialog is resized
* the Parameters label should be aligned to the top and there should be only 2px between 
the label and the list

The UI spec would clarify this better.

We use JLF guidelines for laying out components:
http://java.sun.com/products/jlf/ed2/book/HIGTOC.nf.html

Yes, the implementation of J2SE method dialogs isn't according to the spec, which is at 
(note that this spec has also some issues):
http://ui.netbeans.org/nonav/docs/hi/promoD/jdk15support.html
Comment 3 John Jullion-ceccarelli 2005-03-10 10:26:46 UTC
Please use the UI keyword for all bugs that affect the UI. Does this bug affect
display text or just layout? Will it be fixed for 4.1?
Comment 4 Jiri Kopsa 2005-03-11 09:10:16 UTC
The changes should apply only to the layout and it should be fixed in 4.1 (in my
opinion).
Comment 5 Jiri Kopsa 2005-03-23 11:07:56 UTC
Update: the Add * Method dialog might be changed a little more (not just a
layout), since we need to solve also #55494.

I'm adding a dependency.
Comment 6 Jiri Kopsa 2005-04-01 11:27:45 UTC
Except the workflow enhancement (based on the #55494), the layout of the dialogs
needs to be repaired.

1. The spacing between the parameters/exception panes and bottom border of the
tabs should be 11 pixels.

2. The validation message should not have a border and background.

These two points apply to all Add * Method (Parameters/Exceptions tabs) in J2EE.

3. EJB QL text area should have a border (Add Finder Method, Add Select Method)

4. Is the font in EJB QL text area correct? It should be the same as the one
used in text fields.
Comment 7 Jiri Kopsa 2005-04-01 13:41:57 UTC
It seems that 2) is only a problem on WinXP. I'm attaching a screenshot.

The validaiton message should look the same as in wizards.
Comment 8 Jiri Kopsa 2005-04-01 13:42:27 UTC
Created attachment 21289 [details]
Add Method dialog on Windows XP
Comment 9 Martin Adamek 2005-04-02 13:25:28 UTC
Fixed.

> 4. Is the font in EJB QL text area correct? It should be the same as the one
used in text fields.

It's the same font. No special settings for QL JTextArea.

/cvs/j2ee/utilities/src/org/netbeans/modules/j2ee/common/ui/nodes/MethodCustomizer.java,v
 <--  MethodCustomizer.java; new revision: 1.16; previous revision: 1.15
/cvs/j2ee/utilities/src/org/netbeans/modules/j2ee/common/ui/nodes/MethodCustomizer.form,v
 <--  MethodCustomizer.form; new revision: 1.7; previous revision: 1.6
Comment 10 L Martinek 2005-07-13 16:36:55 UTC
v.