This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 54613 - core/windows tests are failing
Summary: core/windows tests are failing
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2005-02-07 09:16 UTC by Jaroslav Tulach
Modified: 2008-12-22 22:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2005-02-07 09:16:47 UTC 
Module: core/windows
--------------------

Suite:
org.netbeans.core.windows.persistence.ModeParserTest
Test Case: testLoadMode05
Last failed: 200502031900

Suite:
org.netbeans.core.windows.persistence.TCGroupParserTest
Test Case: testLoadTCGroup01
Last failed: 200502021900
Test Case: testSaveTCGroup01
Last failed: 200502021900

Suite:
org.netbeans.core.windows.persistence.WindowManagerParserTest
Test Case: testSaveWM01
Last failed: 200502031900
Test Case: testSaveWM02
Last failed: 200502031900
Comment 1 Stanislav Aubrecht 2005-02-07 16:56:00 UTC 
the had been actually already fixed before this issue was raised (i
just didn't update the test reports)

i couldn't get the TCGroupParserTest test to fail though.


+++ ModeParserTest.java	4 Feb 2005 11:09:50 -0000
@@ -261,7 +261,7 @@
 //        assertEquals("Mode frame
state",Frame.MAXIMIZED_BOTH,modeCfg.frameState);
         
         assertEquals("Active
TC","output",modeCfg.selectedTopComponentID);
-        assertFalse("Permanent",modeCfg.permanent);
+        assertTrue("Permanent",modeCfg.permanent);
         
         System.out.println("ModeParserTest.testLoadMode05 FINISH");
     }


RCS file:
/cvs/core/windows/src/org/netbeans/core/windows/persistence/ModeConfig.java,v
retrieving revision 1.5
diff -u -r1.5 ModeConfig.java
--- ModeConfig.java	16 Nov 2004 10:22:37 -0000	1.5
+++ ModeConfig.java	4 Feb 2005 13:15:07 -0000
@@ -80,7 +80,9 @@
         if ((state != modeCfg.state) || (kind != modeCfg.kind)) {
             return false;
         }
-        if (side != modeCfg.side) {
+        if (null != side && !side.equals( modeCfg.side ) ) {
+            return false;
+        } else if( null == side && null != modeCfg.side ) {
             return false;
         }
         //Order of constraints array is defined
Comment 2 David Simonek 2005-02-25 09:05:24 UTC 
Standa, please look at this again, tests are failing each day in
test4u infrastructure.
Comment 3 Stanislav Aubrecht 2005-02-25 09:47:29 UTC 
the problem is i can't reproduce it on my windows machine.
and the error messages suggest that it is the test setup that is
failing, not the test itself.
i'll see what i can do.
Comment 4 Stanislav Aubrecht 2005-03-11 12:24:00 UTC 
fixed

Checking in windows/test/cfg-unit.xml;
/cvs/core/windows/test/cfg-unit.xml,v  <--  cfg-unit.xml
new revision: 1.11; previous revision: 1.10
done
Comment 5 Zdenek Konecny 2005-07-18 13:07:52 UTC 
Verified