This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 54476 - Remove unnecessary custom ant tasks
Summary: Remove unnecessary custom ant tasks
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Pavel Buzek
URL:
Keywords:
Depends on: 49712 50676 55992 56023
Blocks: 52155 52259
  Show dependency tree
 
Reported: 2005-02-03 14:26 UTC by Jaroslav Tulach
Modified: 2005-03-25 14:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2005-02-03 14:26:56 UTC
They again form an API that we have to maintain
and if we can  work without them (like in case of 
issue 50676) we shall remove them.

See 
http://openide.netbeans.org/tutorial/reviews/opinions_52155.html#ant-tasks
Comment 1 Vince Kraemer 2005-02-08 18:40:27 UTC
I found a couple custom tasks in the J2ee arena:

CopyFiles and WSCompile

I am assigning this to Pavel.  I know this task is in there for a
reason, but I want to get that reason from the author.

After that, It probably needs to get assigned to Peter Wiliams for
further comment.
Comment 2 Petr Jiricka 2005-02-10 13:36:45 UTC
There are also the JSP compilation tasks, but I don't think these are
unnecessary and can be removed.
Comment 3 Pavel Buzek 2005-02-19 03:28:40 UTC
The JspCSingle task is there bcs the apache JspC task cannot be setup
to compile one JSP via attributes from ant script (but can be
programatically). As far as I can tell JspC is there to improve error
reporting in output tab.

Copyfiles is the one that can be removed. WS was added w/ knoledge
that this issue is filed :-) and need investigation.

The bad thing is that custom tasks require the jar files on ant's
classpath so they make it harder to cvs co and build the project w/o
netbeans. Jardo feel free to correct me.

AFAIK this is a P1 mainly because it is a TCR.
Comment 4 Pavel Buzek 2005-02-28 03:37:52 UTC
update: copyfiles removed from web/project, ejbjarproject and
earproject needs to folow (I plan to do it)
Comment 5 _ pcw 2005-03-07 02:06:33 UTC
Please see my lengthy comment on the wscompileuptodate task in bug
#49712 which explains why we need that task and why the reasons to
remove copyfiles do not necessarily apply to it.  If someone has some
ideas on how to solve the problem without using a custom task, I'd be
open to it but not solving the issue raised in 49712 is much worse
than providing a custom task for it in my opinion.
Comment 6 _ ludo 2005-03-17 03:51:32 UTC
any update on this?
Comment 7 Pavel Buzek 2005-03-17 04:09:52 UTC
There were several regression caused by removal of copyfiles from web/project.
Now there is one more issue, see #56140, I am working on it.
Comment 8 Marek Fukala 2005-03-25 10:44:17 UTC
The copyfiles task was removed also from ejb (Issue #55992) and ear project
(Issue #56023). There has to be fixed some regressions though. They are filled
as separate issues.
Comment 9 Pavel Buzek 2005-03-25 14:12:36 UTC
You forgot that CopyFiles class still needs to be removed.
We should also rename the jar file to something else, copyfile.jar will contain
JspC and JspCSingle.
Comment 10 Petr Jiricka 2005-03-25 14:24:44 UTC
We were talking about this - will not removing copyfiles be a problem for 4.0
projects? It is possible to open a 4.0 project without upgrading it I believe -
do we need to keep copyfiles for this?

What do you suggest as the new jar file name?
Comment 11 Pavel Buzek 2005-03-25 14:41:31 UTC
True, this would be a problem. This means we need to keep the name of jar file
the same and keep the CopyFiles class. It is not a big issue, I just wanted to
clean up and forgot about this. Thanks.

Ok, we can possibly remove the task later (maybe 4.2 or such).