This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53459 - Allow to brand icon of PageSetup Action
Summary: Allow to brand icon of PageSetup Action
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Actions (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-14 23:56 UTC by Peter Zavadsky
Modified: 2008-12-22 19:18 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Edited diff of hack (449 bytes, text/plain)
2005-01-14 23:57 UTC, Peter Zavadsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Zavadsky 2005-01-14 23:56:07 UTC
We need to have a possibility to brand the actions
icon, see the umbrella issue, beside the plain
branding (using Utilities.loadImage(String,
boolean), there is a need to be able to brand
different extension (png) too.
Comment 1 Peter Zavadsky 2005-01-14 23:57:00 UTC
Created attachment 19714 [details]
Edited diff of hack
Comment 2 Peter Zavadsky 2005-01-14 23:58:13 UTC
I was probably misleading, the Utilities.loadImage(str, boolean) is
used from action.

Here is needed to provide the resource path from Bundle, so it is
possible to brand.
Comment 3 Petr Nejedly 2005-01-19 08:32:27 UTC
No need to touch the openide code at all.
Just provide your own image in file named
org/openide/resources/actions/pageSetup_yourbranding.gif

and once you start the app using yourbranding, it will use your icon
as well.
Comment 4 Peter Zavadsky 2005-01-19 17:57:19 UTC
You've missed the point (see the diff). The problem is, there is a
desire to be able to brand it by another extension, in this case by
.png file, instead of the .gif
Comment 5 Peter Zavadsky 2005-01-20 00:20:18 UTC
OK, I changed the icon to gif and branded it. Closing this, and
leaving the possible solution for using diff formats to the umbrella
issue.
Comment 6 Petr Nejedly 2005-01-20 10:15:26 UTC
I forgot to tell you that you can use an icon in PNG format, you just
need to _rename_ it to .gif ;-)
We're using it in NB regulary, otehrwise we won't have shaded icons.
(see e.g. openide/resources/actions/paste.gif)
Comment 7 Peter Zavadsky 2005-01-20 19:43:45 UTC
Yes, I realized that you are using that trick. Is the rationale behind
that java loads the image and recognizes the format based on its content?
Will it be somehow solved in future, so there is avoided this 'trick'?
Comment 8 Petr Nejedly 2005-01-26 11:25:11 UTC
Yes, java recognizes the file header.
For future, we may switch to .pngs entirely, but:
1. Trying both extensions is too expensive.
2. The change to .png only would be a big trouble for branders.