This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53457 - Allow branding of NbSheet icon
Summary: Allow branding of NbSheet icon
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-14 23:39 UTC by Peter Zavadsky
Modified: 2008-12-22 19:12 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
edited diff, showing the current hack (605 bytes, patch)
2005-01-14 23:39 UTC, Peter Zavadsky
Details | Diff
Edited diff of required patch (620 bytes, patch)
2005-01-20 22:46 UTC, Peter Zavadsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Zavadsky 2005-01-14 23:39:18 UTC
We need to have a way to brand the NbSheet icon.
See the diff, showing current hack.
Comment 1 Peter Zavadsky 2005-01-14 23:39:44 UTC
Created attachment 19712 [details]
edited diff, showing the current hack
Comment 2 David Simonek 2005-01-19 15:10:33 UTC
Passing to Martin to distribute bugs evenly. Thanks Martine :-)
Comment 3 Peter Zavadsky 2005-01-20 22:45:31 UTC
Attaching new diff, which actually better describes what is required,
(in the sense the png icons are handled by the renaming to gif trick)
Comment 4 Peter Zavadsky 2005-01-20 22:46:23 UTC
Created attachment 19842 [details]
Edited diff of required patch
Comment 5 Peter Zavadsky 2005-01-20 22:47:19 UTC
Consult the possible patch with Petr, according to performance (CC'ing
him).
Comment 6 Martin Krauskopf 2005-01-26 09:43:06 UTC
Petre, do you have any comments according to the perfromance. I think
that the loadImage is called only once. Or is the problem somewhere else?
Comment 7 Petr Nejedly 2005-01-26 11:09:34 UTC
Yes, in this case, the call would be very rare, at most. No problem
with it from the performance point of view.
Comment 8 Martin Krauskopf 2005-01-26 12:43:49 UTC
Thanks for the patch -> applied -> fixed.

Checking in core/src/org/netbeans/core/NbSheet.java;
new revision: 1.25; previous revision: 1.24
Comment 9 Marian Mirilovic 2006-01-18 15:03:45 UTC
fixed long time ago without any additional comments - verified