This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53237 - Overcomplicated threading in JavaNode
Summary: Overcomplicated threading in JavaNode
Status: CLOSED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Pokorsky
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2005-01-11 15:01 UTC by Petr Nejedly
Modified: 2007-09-26 09:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2005-01-11 15:01:01 UTC 
JavaNode uses too complicated logic for icon updates:

JavaNode.requestResolveIcons()
  -> RP(1000ms)
   -> IconResolver.run() ->
StateUpdater.updateNode() ->
     -> joined Timer(300ms)
       -> RP(0ms)
        -> JavaNode.resolveIcons -> compute
          -> invokeLater() -> setBadges()

There are two RPs used and also a Swing Timer.
There are two delays, the timer is used only for
delaying and rescheduling, a task that can be
easily done by the RP itself.
Comment 1 Martin Matula 2005-01-13 11:00:34 UTC 
Honza, please look at it.
Comment 2 Jan Pokorsky 2005-02-01 14:34:55 UTC 
fixed in

/cvs/java/src/org/netbeans/modules/java/JavaNode.java
new revision: 1.124; previous revision: 1.123
Comment 3 Jiri Prox 2005-07-12 16:35:14 UTC 
Petre, can you verify this issue, please? Thanks.
Comment 4 Petr Nejedly 2005-07-15 09:37:52 UTC 
It's verified