This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 52689 - InstanceDataObjectModuleTest7.testFixedSettingsChangeInstanceAfterSlowReload can leave m2 enabled
Summary: InstanceDataObjectModuleTest7.testFixedSettingsChangeInstanceAfterSlowReload ...
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 4.x
Hardware: Sun Solaris
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2004-12-20 17:25 UTC by Jesse Glick
Modified: 2008-12-23 08:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-12-20 17:25:42 UTC 
No idea why, but apparently sometimes on Solaris
tester machines IDOMT7.tFSCIASR will fail with

java.lang.IllegalArgumentException: enabled
module: Module:test2
	at
org.netbeans.core.modules.ModuleManager.delete(ModuleManager.java:615)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTestHid$2.run(InstanceDataObjectModuleTestHid.java:113)
	at org.openide.util.Mutex.writeAccess(Mutex.java:310)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTestHid.tearDown(InstanceDataObjectModuleTestHid.java:110)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTest7.tearDown(InstanceDataObjectModuleTest7.java:68)

Of course I cannot reproduce. Will try to enable
logging in the test and add it when the test fails
with an error, maybe that will help. (Yarda
already has errors attached to test failures, but
this is an error in tearDown.)
Comment 1 Jesse Glick 2004-12-20 22:04:05 UTC 
committed     Up-To-Date  1.11       
core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTestHid.java
Comment 2 Jaroslav Tulach 2005-01-03 08:05:09 UTC 
Fails every second day with message bellow. Probably the logging is
not correct?


testFixedSettingsChangeInstanceAfterSlowReload:
      java.lang.IllegalArgumentException: enabled module: Module:test2
	at org.netbeans.core.modules.ModuleManager.delete(ModuleManager.java:615)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTestHid$2.run(InstanceDataObjectModuleTestHid.java:113)
	at org.openide.util.Mutex.writeAccess(Mutex.java:310)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTestHid.tearDown(InstanceDataObjectModuleTestHid.java:110)
	at
org.netbeans.core.lookup.InstanceDataObjectModuleTest7.tearDown(InstanceDataObjectModuleTest7.java:68)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at org.netbeans.junit.NbTestCase.run(NbTestCase.java:119)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at
org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:176)
	at
org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:127)
	at
org.netbeans.xtest.plugin.jvm.JUnitTestRunnerLauncher.main(JUnitTestRunnerLauncher.java:41)
Comment 3 Jesse Glick 2005-01-03 18:30:14 UTC 
The logging was indeed not correct. The actual error was apparently
caused by some failure in the test body, which the tearDown method did
not handle correctly. I fixed that. I then found some other use of
try-finally in the test body which was unnecessary and possibly could
result in meaningless errors, which I also fixed. I also made sure
that the test is only run with the correct classpath as it can fail
strangely if not. Then it passes for me. I presume that somewhere in
there, there was some actual test failure, but now I cannot find it.
If it happens again, at least the error message should be more sensible.
Comment 4 Jesse Glick 2005-01-03 21:23:25 UTC 
Let's try again.

committed   * Up-To-Date  1.11       
core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTest7.java
committed   * Up-To-Date  1.12       
core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTestHid.java
Comment 5 Jaromir Uhrik 2005-07-14 16:19:19 UTC 
Verified.