This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51062 - Jump to Previous/Next edit (Alt+K, Alt+L) does not work after Goto Source/Declaration (Alt+O, Alt+G)
Summary: Jump to Previous/Next edit (Alt+K, Alt+L) does not work after Goto Source/Dec...
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Key bindings (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: issues@editor
URL:
Keywords: REGRESSION
: 51102 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-02 09:31 UTC by Marian Petras
Modified: 2007-11-05 13:40 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Petras 2004-11-02 09:31:39 UTC 
Pressing Alt-L causes the same action as Alt-K.

Alt-K should jump to the previous editor position.
It works as designed.

Pressing Alt-L should jump to the _next_ editor
position (only applicable after we jumped back).
But Alt-L jumps to the _previous_ position, which
is wrong.
Comment 1 Dusan Balek 2004-11-02 10:09:03 UTC 
The problem is that Goto Source/Declaration actions don't add
destination positions to the jump list. Raising priority to P2 as it
is a regression.
Comment 2 Dusan Balek 2004-11-02 10:46:05 UTC 
Fixed in [maintrunk].

Destination positions of the Goto Source/Declaration actions added to
the JumpList.

Checking in JMIUtils.java;
/cvs/editor/src/org/netbeans/modules/editor/java/JMIUtils.java,v  <--
 JMIUtils.java
new revision: 1.62; previous revision: 1.61
done

Mila, could you please review the fix.

Visual diff:
http://editor.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/JMIUtils.java.diff?r1=1.61&r2=1.62
Comment 3 Miloslav Metelka 2004-11-02 13:51:56 UTC 
The fix is fine although I personally prefer retaining of the
individual imports in the source rather than a single .* import.
Comment 4 Dusan Balek 2004-11-03 07:02:12 UTC 
*** Issue 51102 has been marked as a duplicate of this issue. ***
Comment 5 Jaromir Uhrik 2004-11-04 10:29:05 UTC 
The fix works fine in maintrunk build #200411031900; jdk1.5.0_01b05. I
agree with integration to release40.
Comment 6 Dusan Balek 2004-11-04 14:09:34 UTC 
Integrated into [release40].

Checking in JMIUtils.java;
/cvs/editor/src/org/netbeans/modules/editor/java/JMIUtils.java,v  <--
 JMIUtils.java
new revision: 1.61.2.1; previous revision: 1.61
done
Comment 7 Jaromir Uhrik 2004-11-05 13:52:44 UTC 
Verified in release40 branch build #200411041919; jdk1.5.0_01-b05.