This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51020 - [tests] Missing events after modifing a constructor, method and field
Summary: [tests] Missing events after modifing a constructor, method and field
Status: CLOSED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Martin Matula
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-01 09:34 UTC by ehucka
Modified: 2007-09-26 09:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ehucka 2004-11-01 09:34:01 UTC
automated tests: java/qa-functional, eventfiring

There is missing an event after a constructor is
removed, an event after a field's type is changed
and after a return type of a method is changed.
Comment 1 Jan Becicka 2004-11-01 10:25:17 UTC
I assume this issue is a regression. Emane which build is the last
good one please? Thanks
Comment 2 ehucka 2004-11-01 10:37:40 UTC
Build 200410261800 passed without problems. At the first time I see it
in tests with 200410271800. It is 100% reproducible by tests.
Comment 3 Jan Becicka 2004-11-01 12:30:53 UTC
Probably regression in the bridge. Commit from 10/27 is yours, Dane,
can you take a look at it, please? Thanks

User: dprusa 
  Date: 04/10/27 08:44:44

  Modified:    src/org/netbeans/modules/java/bridge CallableImpl.java
                        FeaturesCollection.java FieldElementImpl.java
                        MethodElementImpl.java
  Log:
  setting/getting of primitive types changed - setType/getType is used
instead of setTypeName/getTypeName
Comment 4 Martin Matula 2004-11-02 10:32:04 UTC
I'll look at this.
Comment 5 Martin Matula 2004-11-02 13:54:02 UTC
Fixed.

Checking in src/org/netbeans/modules/java/bridge/CallableImpl.java;
/cvs/java/src/org/netbeans/modules/java/bridge/CallableImpl.java,v 
<--  CallableImpl.java
new revision: 1.12; previous revision: 1.11
done
Checking in src/org/netbeans/modules/java/bridge/FieldElementImpl.java;
/cvs/java/src/org/netbeans/modules/java/bridge/FieldElementImpl.java,v
 <--  FieldElementImpl.java
new revision: 1.10; previous revision: 1.9
done
Checking in src/org/netbeans/modules/java/bridge/MethodElementImpl.java;
/cvs/java/src/org/netbeans/modules/java/bridge/MethodElementImpl.java,v
 <--  MethodElementImpl.java
new revision: 1.8; previous revision: 1.7
done
Comment 6 Martin Matula 2004-11-02 15:16:21 UTC
The previous fix is not very clean - it fixes the problem only for the
source hierarchy api. I am going to revert it and commit a better one.
Comment 7 Martin Matula 2004-11-02 15:41:56 UTC
OK, I've reverted the previous change and commited a new fix:

Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/FieldImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/FieldImpl.java,v
 <--  FieldImpl.java
new revision: 1.17; previous revision: 1.16
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/MethodImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/MethodImpl.java,v
 <--  MethodImpl.java
new revision: 1.15; previous revision: 1.14
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/ParameterImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ParameterImpl.java,v
 <--  ParameterImpl.java
new revision: 1.9; previous revision: 1.8
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/SemiPersistentElement.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/SemiPersistentElement.java,v
 <--  SemiPersistentElement.java
new revision: 1.56; previous revision: 1.55
done
Comment 8 Martin Matula 2004-11-02 15:47:01 UTC
Commited to trunk, waiting for approval to fix it in the branch.
Comment 9 Jan Chalupa 2004-11-03 13:00:57 UTC
Changing TM. Resolved fixed for 4.1 at the moment. Please change TM
back to 4.0 after integrating the fix into 'release40'. Thanks.
Comment 10 Tomas Hurka 2004-11-03 14:00:10 UTC
I have reviewed the fix in trunk and agree with it.
Comment 11 Martin Matula 2004-11-04 08:44:56 UTC
Integrated to release40 branch.

Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/FieldImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/FieldImpl.java,v
 <--  FieldImpl.java
new revision: 1.16.8.1; previous revision: 1.16
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/MethodImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/MethodImpl.java,v
 <--  MethodImpl.java
new revision: 1.14.8.1; previous revision: 1.14
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/ParameterImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ParameterImpl.java,v
 <--  ParameterImpl.java
new revision: 1.8.8.1; previous revision: 1.8
done
Checking in
src/org/netbeans/modules/javacore/jmiimpl/javamodel/SemiPersistentElement.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/SemiPersistentElement.java,v
 <--  SemiPersistentElement.java
new revision: 1.55.2.1; previous revision: 1.55
done
Comment 12 ehucka 2004-11-08 12:51:20 UTC
verified