This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 50815 - Javacore should not depend on project API
Summary: Javacore should not depend on project API
Status: RESOLVED WONTFIX
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@java
URL:
Keywords: ARCH
Depends on: 87969
Blocks:
  Show dependency tree
 
Reported: 2004-10-25 16:32 UTC by Jesse Glick
Modified: 2007-09-26 09:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-10-25 16:32:33 UTC
Currently it apparently does so only to avoid
automatic scanning of the "source root" supplied
by the fallback classpath provider, as doing so
can cause serious performance and correctness
problems if a stray Java file is lying around
somewhere.

Should be solved properly (too late for D). Perhaps

- in conjunction with an includes/excludes API for
sourcepaths, have fallback provider request
inclusion only of the file it was called on (cf.
issue #49371)

- make javacore scanning of classpaths which are
not in GlobalPathRegistry (whether in projects or
not) and not already scanned somehow lazy, i.e. do
not go looking for other classes in the same root;
any features which would depend on knowing
possible names of classes in that sourceroot whose
FQN is not known (e.g. Fix Imports) should be
disabled on such files or show an error message or
just offer to scan eagerly
Comment 1 Jesse Glick 2004-10-25 16:33:46 UTC
Desirable for 4.1; architectural flaw introduced at the last minute in
4.0 (unavoidably, it seems).
Comment 2 Martin Matula 2004-10-25 17:15:17 UTC
Lowering priority per agreement with Jesse. The priority should be set
back to P2 after 4.0 is released.
Comment 3 Jesse Glick 2004-10-25 17:46:43 UTC
I just saw that dbalek also added a project API dep, e.g. in rev. 1.10
of NbJavaJMIFastOpen.java, though I cannot see anything in the issues
mentioned in the commit log that relate to FileOwnerQuery. Was this
change related to the javacore change, or should I file a separate
arch bug for editor?
Comment 4 Tomas Zezula 2004-10-25 18:07:50 UTC
This is not the same. Dusan uses the FOQ to find out which files
belongs to project to be able to filter out the non project classes in
the Fast Open Dialog (when show only project classes option is checked).
Comment 5 Jesse Glick 2004-10-25 18:18:38 UTC
OK, I filed issue #50821 for the editor.
Comment 6 Jan Becicka 2006-10-26 16:26:57 UTC
Javacore module was replaced by Retouche infrastructure. This bug is not valid
in trunk any more.
Comment 7 Jesse Glick 2006-10-26 21:03:53 UTC
Not exactly true. GoToTypeAction uses project APIs for displaying associated
project name.
Comment 8 Jesse Glick 2006-10-26 21:05:17 UTC
...but probably will not change that (cf. issue #87969).
Comment 9 Quality Engineering 2007-09-20 11:55:51 UTC
Reorganization of java component