This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 50710 - No profiles available in New Wizard - Generic CVS
Summary: No profiles available in New Wizard - Generic CVS
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: PC Unix
: P3 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: API, API_REVIEW_FAST
: 51692 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-21 15:26 UTC by _ mriem
Modified: 2008-12-22 10:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed patch (3.65 KB, patch)
2004-10-25 14:44 UTC, Jiri Rechtacek
Details | Diff
fixed diff (5.99 KB, patch)
2004-10-26 09:51 UTC, Jiri Rechtacek
Details | Diff
maybe a useless test (15.50 KB, patch)
2004-10-26 09:53 UTC, Jiri Rechtacek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ mriem 2004-10-21 15:26:03 UTC
When opening the Versioning Manager and then 
pressing Add the New Wizard - Generic CVS wizard 
does NOT contain the expected profiles as in 
Windows (missing CVS and the other profiles).

This bug is probably related to the issue 50708
Comment 1 Martin Entlicher 2004-10-21 17:07:53 UTC
It seems that issue #50708 is just a consequence of this.
I guess you did not uninstall any modules, did you? It might be
specific to FreeBSD, because the profiles are enabled only on UNIX (or
Windows) systems. If FreeBSD is not detected as a UNIX system, it can
cause this bug.
Can you please provide what gives you System.getProperty("os.name")?
Comment 2 _ mriem 2004-10-21 17:33:48 UTC
No a fresh install actually of the Linux version. Could that be the 
problem? FreeBSD allows you to brand an executable as Linux. The 
install went OK, no problems there.

From the messages.log file:

Operating System = FreeBSD version 5.2.1-SECURITY running on i386
Java; VM; Vendor = 1.4.2-p6; Java HotSpot(TM) Client VM 1.4.2-p6-
manfred_19_jun_2004_20_02; Sun Microsystems Inc.
Java Home        = /usr/local/jdk1.4.2/jre

Simple program gives it as: FreeBSD
Comment 3 Martin Entlicher 2004-10-21 17:39:58 UTC
Thanks for the info. It looks that "FreeBSD" is not listed in
org.openide.Utilities.getOperatingSystem(). Therefore it's not
detected as a UNIX system. Moving to openide module.
Comment 4 Martin Entlicher 2004-10-21 17:42:45 UTC
What is the correct subcomponent? It's in util package. Does it have
an owner? The fix is trivial, so it would be a pity not to have it
fixed in 4.0.
Comment 5 Jiri Rechtacek 2004-10-25 14:43:36 UTC
Please, reviewers consider the attached proposed change in
openide/util/Utilities. This change adds the FreeBSD in family of Unix
OS. It easy and secure change, doable to NB4.0. Reason? This fix made
FreeBSD to be recognized as Unix OS and its profiles in CVS Wizard
won't be empty. Thanks
Comment 6 Jiri Rechtacek 2004-10-25 14:44:14 UTC
Created attachment 18489 [details]
proposed patch
Comment 7 Jaroslav Tulach 2004-10-25 14:59:37 UTC
Field should not be named OS_FEEEBSD - is not fee oposite to free? Are
not that two words? In such case OS_FREE_BSD is the prefered constant
name.

Also the change id should be more descriptive, I am pretty sure, there
will be more fixes for FreeBSD in future.

Otherwise harmless I think.
Comment 8 Jiri Rechtacek 2004-10-25 15:11:52 UTC
Thanks for notice, I have seen OS_FEEEBSD when I attached patch to
issue :-( I'll fix it before merge.
I'll make the record in apichanges to more descriptive.
Comment 9 Jesse Glick 2004-10-25 17:00:01 UTC
Also looks OK to me; second Yarda's comments about constant name.

Patch:

Maybe we should be using 1 << 0, 1 << 1, 1 << 2, 1 << 3, etc. for OS
constants rather than 1, 2, 4, 8, etc. Up to 65536 it's pretty easy to
spot typos, but around 131072 I start to forget. :-)

Get in the habit of using osName.toLowerCase(Locale.US) rather than
osName.toLowerCase(), since you don't really want to use
locale-sensitive case operations here I think! Probably doesn't make
any difference in this case, but only because the string you are
comparing to does not happen to contain the letter 'i'.

apichanges.xml:

Don't use "util/Utilities" to refer to the class. Use "Utilities" - or
if necessary "org.openide.util.Utilities", but here it probably isn't
since the <class> element will give a hyperlink anyway.

<issue> does not belong there. Validate your XML when you save it.
Comment 10 Jiri Rechtacek 2004-10-26 09:50:51 UTC
Thanks for comments, I attach new fixed diff.
Comment 11 Jiri Rechtacek 2004-10-26 09:51:25 UTC
Created attachment 18512 [details]
fixed diff
Comment 12 Jiri Rechtacek 2004-10-26 09:53:25 UTC
Created attachment 18513 [details]
maybe a useless test
Comment 13 Jaroslav Tulach 2004-10-26 14:04:08 UTC
I am impressed by the "so called useless" test.
Comment 14 Jiri Rechtacek 2004-10-29 09:02:39 UTC
Thanks for comments. The fixed patch has been integrated in main trunk.
Comment 15 Jiri Rechtacek 2004-10-29 09:03:18 UTC
Checking in openide-spec-vers.properties;
/cvs/openide/openide-spec-vers.properties,v  <-- 
openide-spec-vers.properties
new revision: 1.160; previous revision: 1.159
done
Processing log script arguments...
More commits to come...
Checking in api/doc/changes/apichanges.xml;
/cvs/openide/api/doc/changes/apichanges.xml,v  <--  apichanges.xml
new revision: 1.226; previous revision: 1.225
done
Processing log script arguments...
More commits to come...
Checking in src/org/openide/util/Utilities.java;
/cvs/openide/src/org/openide/util/Utilities.java,v  <--  Utilities.java
new revision: 1.146; previous revision: 1.145
done
Processing log script arguments...
More commits to come...
RCS file: /cvs/openide/test/unit/src/org/openide/util/UtilitiesTest.java,v
done
Checking in test/unit/src/org/openide/util/UtilitiesTest.java;
/cvs/openide/test/unit/src/org/openide/util/UtilitiesTest.java,v  <--
 UtilitiesTest.java
initial revision: 1.1
done
Comment 16 Martin Entlicher 2004-11-22 09:07:21 UTC
*** Issue 51692 has been marked as a duplicate of this issue. ***
Comment 17 Marian Mirilovic 2005-12-20 15:46:52 UTC
This issue was solved long time ago. Because nobody has reopened it neither
added comments, we are verifying/closing it now. 
If you are still able to reproduce the problem, please reopen. Thanks in advance.