This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 50150 - Changing method parameters in properties dialog doesn't invoke refactoring
Summary: Changing method parameters in properties dialog doesn't invoke refactoring
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@java
URL:
Keywords: UI
: 47449 53376 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-08 09:01 UTC by jrojcek
Modified: 2007-09-26 09:14 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2004-10-08 09:01:45 UTC
It is possible to change modifiers or parameters of a method 
using its properties and the refactoring is not invoked.

On the contrary it is not possible to change the method name at 
all using the method properties.

Probably, if the user wants to change a method name or 
parameters using the method properties, the refactoring dialogs 
should be shown after clicking on [...] button.
Comment 1 Martin Matula 2004-10-08 09:10:56 UTC
For 4.0 we will probably disable the modification of those properties.
We can consider invocation of the refactoring as an enhancement for
the future.
Honzo, can we make those properties read-only?
Comment 2 Jan Pokorsky 2004-10-08 15:51:51 UTC
1. modifiers are customizable as a r/w node property - it is ok IMO
since refactoring offers nothing special in this case. In the property
customizer you can change access + others(final, static, ...). The
refactoring permits to change just the access(visibility). It does not
prevent you to change public -> private even if it breaks the code.

2. method parameters are already r/o node property. It is a bug of the
associate customizer that it makes an impression you can add
something. The Add button should be disabled. Nevertheless your
changes are not applied to code. So this should be fixed in nb 4.0.

3. You can also change return type and exceptions as the node
properties. Again, refactoring offers nothing special in these cases.

We agreed on this with gtichy when we worked on the ui spec for jdk
1.5 features.

IMHO, we should reconsider these properties as a whole. I propose to
get rid of them at all in nb 4.1. Who edits code via them? The editor
is the place where you type the code so why to traverse the explorer
in order to invoke refactoring? I simply see no value in visualizing
source code in the property sheet.
Comment 3 Jan Becicka 2004-10-19 17:28:36 UTC
Honzo, please set target milestone. Thanks
Comment 4 Jan Pokorsky 2004-10-19 18:01:54 UTC
no opinion from HIEs?
Comment 5 dpavlica 2004-10-26 14:47:48 UTC
Fine summary Honzo and I agree, that we should consider to remove 
this Property dialog for method at all in the next release.

PS: There are two properties which could be moved close to a code:
Exceptions ... Could be invoked from suchlike Proactive Suggestion 
popup menu (Which exists already in Eclipse or Idea).
Javadoc Comments ... There is another way how to invoke AutoComment 
tool or it could be added as a new toggle button in the Editor's 
toolbar.
Comment 6 Jan Pokorsky 2005-02-14 15:25:02 UTC
Dusan, what is the result of your consideration? Have you updated the
ui spec?
Comment 7 Jan Becicka 2005-02-14 15:27:19 UTC
AFAIK responsible xDesign engineer is Rudolf Bock.
Comment 8 Jan Pokorsky 2005-02-14 15:42:09 UTC
*** Issue 53376 has been marked as a duplicate of this issue. ***
Comment 9 Jan Pokorsky 2005-02-14 15:56:41 UTC
Great, so hopefully Rudolf will project xDesigner's considerations to
some document, preferably ui specification.
Comment 10 Jan Pokorsky 2005-02-15 12:55:11 UTC
*** Issue 47449 has been marked as a duplicate of this issue. ***
Comment 11 Rudolf Bock 2005-03-17 19:41:13 UTC
I agree with Dusan Pavlica
Comment 12 Tomas Zezula 2007-02-16 15:24:10 UTC
The methods have no property sheets anymore.