This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47975 - MasterFileObject.getParent rather slow
Summary: MasterFileObject.getParent rather slow
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 4.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: rmatous
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 47910
  Show dependency tree
 
Reported: 2004-08-26 03:52 UTC by Jesse Glick
Modified: 2008-12-23 00:39 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-08-26 03:52:37 UTC 
While profiling issue #47910, I found that 1.12%
of CPU (acc. to OptIt) was spent in
MasterFileObject.getParent (forming most of the
time used by FileOwnerQuery), most of that in
finishCriticalSection. Uses Object.notifyAll() and
ThreadLocal; not exactly a lightweight way to
protect access, especially since this is a trivial
r/o operation that could probably be a simple
field retrieval!
Comment 1 rmatous 2004-08-26 09:50:47 UTC 
You are probably right. I also don't see any reason for
synchronization in method getParent. If there any was then I can't
remember anymore.

/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/MasterFileObject.java
new revision: 1.32; previous revision: 1.31
Comment 2 Marian Mirilovic 2005-07-15 07:56:10 UTC 
closed