This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47679 - Storage$EntryType uses subclasses unnecessarilly
Summary: Storage$EntryType uses subclasses unnecessarilly
Status: CLOSED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Martin Matula
URL:
Keywords: PERFORMANCE, SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2004-08-23 09:10 UTC by Petr Nejedly
Modified: 2006-03-24 09:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
A patch that removes subclasses and simplifies searches (4.36 KB, patch)
2004-08-23 09:11 UTC, Petr Nejedly 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2004-08-23 09:10:15 UTC 
There are 4 nearly-trivial subclasses which can be
replaced by parametrized instances. Also the
search code around is quite ineffective.
Comment 1 Petr Nejedly 2004-08-23 09:11:16 UTC 
Created attachment 17019 [details]
A patch that removes subclasses and simplifies searches
Comment 2 Petr Nejedly 2004-08-23 09:14:39 UTC 
The patch is long but the change is straightforward, patch is
available and tested (I'm using it several weeks already).
Marking SIMPLEFIX.
Comment 3 Martin Matula 2004-08-23 09:26:21 UTC 
Good catch! I have reviewed the patch and it is definitely OK - I am
going to integrate it. Thanks.
Comment 4 Martin Matula 2004-08-23 09:51:48 UTC 
Done.

Checking in src/org/netbeans/mdr/persistence/Storage.java;
/cvs/mdr/src/org/netbeans/mdr/persistence/Storage.java,v  <-- 
Storage.java
new revision: 1.9; previous revision: 1.8
done
Comment 5 Petr Nejedly 2004-08-23 10:50:38 UTC 
v