This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47020 - CVS: Add recursively with commit doesn't change the status of files correctly.
Summary: CVS: Add recursively with commit doesn't change the status of files correctly.
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
: 47605 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-09 16:00 UTC by Peter Pis
Modified: 2006-03-24 09:49 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2004-08-09 16:00:34 UTC
>System Info:
  Product Version       = NetBeans IDE Dev (Build
20040809-1150)
  Operating System      = Windows XP version 5.1
running on x86
  Java; VM; Vendor      = 1.5.0-beta3; Java
HotSpot(TM) Client VM 1.5.0-beta3-b6
2; Sun Microsystems Inc.

Steps:
1. Register new CVS versioned directory. (Setup
valid values to some CVS pserver).
2. In versioned directory create new project. In
"Versioning" tab of the explorer invoke "CVS |
Add..." (advance mode) on this new created project.
3. Select "Add All Local Files in Folder
Contents", check "Add the folder contents
recursively", "Proceed with commit if add succeds"
checkboxes.
4. Commit dialog appears. Give some description
for it.

After this, FILES HAVE STATUS [Locally Added] or
[Locally added, New]. But if refresh is executed
on some file, its status changes to [Up-to-date;
1.1]. And this status is correct.
Comment 1 Jiri Kovalsky 2004-08-10 08:48:48 UTC
Please note that this is not a 4.0 Beta 1 showstopper but must be
definetely fixed for next Beta 2 build.
Comment 2 Martin Entlicher 2004-08-11 11:06:31 UTC
Does this happen with command-line client, or built-in client, or both?
Which version of cvs *server* do you use? There is a difference in the
output of commit depending on the version of the cvs server.
Comment 3 Martin Entlicher 2004-08-12 16:16:47 UTC
This must be some strange regression, the 'null' folder appears on
Linux as well.
Comment 4 Martin Entlicher 2004-08-13 11:01:13 UTC
Fixed in trunk. One field was not initialized correctly.

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.23; previous revision: 1.22
Comment 5 Peter Pis 2004-08-16 14:16:00 UTC
Raising priority to P1. It's very annoying.
Comment 6 Martin Entlicher 2004-08-16 16:52:20 UTC
The fix is merged into QBE200408101800 branch:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCommit.java,v
 <--  CvsCommit.java
new revision: 1.22.2.1; previous revision: 1.22
Comment 7 Martin Entlicher 2004-08-22 12:37:13 UTC
*** Issue 47605 has been marked as a duplicate of this issue. ***
Comment 8 _ gtzabari 2004-08-24 06:32:16 UTC
Great, except that now in dev build 200408231800 (fresh userdir) it
tells me "locally modified" beside my filename but the icon associated
with it is a checkmark which means nothing changed. I'm expecting to
see a red circle icon beside the item which indicates "locally
modified". Reopening issue.

PS: Hitting CVS | REFRESH explicitly does not fix the icon problem.
Comment 9 _ gtzabari 2004-08-24 06:34:04 UTC
Workaround: Hitting the PLUS icon beside the modified file caused it
to expand into a folder icon with the red circle beside it. Hitting
MINUS then brings it back to the white icon except that all of a
sudden the red circle is there.
Comment 10 _ gtzabari 2004-08-24 06:36:00 UTC
Sorry, one last issue. I also notice that with this fix I get a CVS |
REFRESH command issued once a second, indefinately. This should be
considered a bug itself. The expected behavior is for CVS | REFRESH to
be issued after a file has been modified (add, commit, etc) but this
command should be issued once.
Comment 11 Martin Entlicher 2004-08-24 11:24:03 UTC
Gili, thanks for your feedback, we have made recently some severe
changes, which could cause regressions.

However, the icon problem (not changing icons) does not seem to be a
regression. I've fixed it in trunk now:
/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/impl/FolderNode.java,v
 <--  FolderNode.java
new revision: 1.5; previous revision: 1.4

The file icon is the same regardless of whether the node is expanded
or not:
/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/impl/FileNode.java,v
 <--  FileNode.java
new revision: 1.6; previous revision: 1.5
Comment 12 Martin Entlicher 2004-08-24 11:29:56 UTC
I did not encounter any problems with Refresh running indefinately.
Perhaps it was fixed by the fix of issue #47698?
Please test the next build (200408241800), if the problem with refresh
persists, please try to describe the steps how to reproduce it. Thanks.
Comment 13 Peter Pis 2004-11-01 12:59:24 UTC
Verified in NB 200410261800.