This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Currently there is no indication of progress of refactoring Undo action, only hour-glass cursor, which is not enough for an operation taking tens of seconds. Also caret is blinking in editor while the Undo action is in progress and the user can modify open files. Which would have unpredictable consequences I guess... Is it also the same case for refactoring actions like Rename?
Undo action should not take tens of seconds. If it takes tens of seconds, it is caused probably by rollbacks (issue 46325).
With mx96m and jEdit renamed to jEditor (which took 3:40) the undo rename took 2:00. Without rollbacks, finished successfully.
Yes, you are right. Dusane, please specify how Undo/Redo progress bar should look like... and reassign this issue back to me. Thanks
This issue should not be ignored... Upgrading to P1. If there is no progress bar and the user is allowed to modify files in the editor while the undo is in progress, it can lead to user file corruption.
In a case that refactoring Undo action (Redo action) takes so much time, there should exist progress indication definitelly. I suggest to create modal dialog similar to Scanning dialog in spec with title: Undo of NameOfRefactoringAction (eventually: Redo of NameOfRefactoringAction) with description: Big amount of changes in code are giving back (or simple label with actual changes of conrete files) and with Progress bar below with number of finished percentage. But we need to merge editor Undo and Refactoring Undo actions in the future and then this dialog will be different a bit. Then it should contain info about difference against normal Editor Undo, asking the question about its execution and buttons Yes/No at the bottom of dialog.
Fixed. Checking in Bundle.properties; /cvs/java/javacore/src/org/netbeans/modules/javacore/Bundle.properties,v <-- Bundle.properties new revision: 1.7; previous revision: 1.6 done RCS file: /cvs/java/javacore/src/org/netbeans/modules/javacore/UndoProgressPanel.form,v done Checking in UndoProgressPanel.form; /cvs/java/javacore/src/org/netbeans/modules/javacore/UndoProgressPanel.form,v <-- UndoProgressPanel.form initial revision: 1.1 done RCS file: /cvs/java/javacore/src/org/netbeans/modules/javacore/UndoProgressPanel.java,v done Checking in UndoProgressPanel.java; /cvs/java/javacore/src/org/netbeans/modules/javacore/UndoProgressPanel.java,v <-- UndoProgressPanel.java initial revision: 1.1 done Processing log script arguments... More commits to come... Checking in internalapi/JavaMetamodel.java; /cvs/java/javacore/src/org/netbeans/modules/javacore/internalapi/JavaMetamodel.java,v <-- JavaMetamodel.java new revision: 1.5; previous revision: 1.4 done Checking in internalapi/UndoManager.java; /cvs/java/javacore/src/org/netbeans/modules/javacore/internalapi/UndoManager.java,v <-- UndoManager.java new revision: 1.6; previous revision: 1.5 done
Verified. The modal dialog box with the progress bar looks good. Just, is the wording of the message correct? "Big amount of changes in code are giving back" Sounds strange to me. :) Tim, is this OK?
"Big amount of changes in code are giving back" :-) It's cute. But probably should be reworded. "Reverting last refactoring..." would work.
Funny label updated. Checking in Bundle.properties; /cvs/java/javacore/src/org/netbeans/modules/javacore/Bundle.properties,v <-- Bundle.properties new revision: 1.9; previous revision: 1.8 done