This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 44248 - overriding no.dependencies to false on command line has no effect
Summary: overriding no.dependencies to false on command line has no effect
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-02 22:37 UTC by Jesse Glick
Modified: 2007-09-26 09:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-06-02 22:37:45 UTC
Doesn't seem to do so anymore, regardless of the
checkbox.

Seems it was broken before - always built them -
but then build-impl.xsl corrected a typo on May 31:

- <xsl:attribute
name="unless">${no.dependencies}</xsl:attribute>
+ <xsl:attribute
name="unless">no.dependencies</xsl:attribute>

which had the effect of exposing the underlying
bug: setting no.dependencies to *any* value (even
false!) makes the target be skipped. Ant treats
any value for a property as true for purposes of
if, unless, etc.

Need to use <condition> and <istrue> to let the
property be set to 'true' or 'false' and handle
that appropriately.
Comment 1 Jesse Glick 2004-06-02 22:38:20 UTC
Bug in j2seproject, but should check web/project too.
Comment 2 David Konecny 2004-06-03 09:15:13 UTC
Yeah, I know about the behaviour of unless/if.

It is broken only for newly created projects because mistakenly the
property is set to "false". When changing this option the property is
correctly set to true or removed from project.properties. I fixed this
be removing property from project generator.

src/org/netbeans/modules/java/j2seproject/J2SEProjectGenerator.java;
new revision: 1.12; previous revision: 1.11
Comment 3 Jesse Glick 2004-06-03 22:38:38 UTC
Wouldn't it be better to use <istrue> so you could override this
setting in either direction (e.g. from the command line)? Not a
priority really.
Comment 4 David Konecny 2004-06-09 10:10:34 UTC
I wanted to move as much conditional logic to Java as possible and
keep Ant script cleaner. But I consider command line ability to
override building of subprojects important. Opening this issue for
myself to fix that.
Comment 5 David Konecny 2004-06-09 10:11:19 UTC
Original regression was fixed. Also not a blocker.
Comment 6 David Konecny 2004-06-10 14:17:54 UTC
Fixed as part of other changes in build-impl.xml.