43485 – org.netbeans.modules.debugger.projects package is misplaced

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 43485 - org.netbeans.modules.debugger.projects package is misplaced

Summary: org.netbeans.modules.debugger.projects package is misplaced

Status:	CLOSED FIXED

Alias:	None

Product:	debugger
Classification:	Unclassified
Component:	Java (show other bugs)
Version:	4.x
Hardware:	All All

Importance:	P1 blocker (vote)
Assignee:	Martin Entlicher

URL:
Keywords:	API_REVIEW_FAST, ARCH

Depends on:
Blocks:	89617
	Show dependency tree

Reported:	2004-05-19 00:06 UTC by Jesse Glick
Modified:	2010-04-29 09:17 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	TASK
Exception Reporter:

Attachments
The proposed changes. (23.11 KB, text/plain) 2006-07-17 17:15 UTC, Martin Entlicher	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jesse Glick 2004-05-19 00:06:04 UTC

For some reason, this package is inside
debuggerjpda/ant/src. Doesn't seem to make any
sense; does not appear to have anything to do with
Ant as such, just with the debugger and the
general Projects API and Projects UI API. Prefer
it to be moved to main debuggerjpda (assuming
there is no reason to avoid a general projects dep
there) or to a separate module.

Comment 1 Jesse Glick 2004-05-19 00:06:21 UTC

General architectural issue.

Comment 2 Jan Jancura 2004-06-01 18:09:01 UTC

accepted

Comment 3 Martin Entlicher 2005-12-12 14:08:14 UTC

True the ANT-related files are inside debuggerjpda/ant/antsrc
debuggerjpda/ant/src can be moved to debuggerjpda/projects/src (a new module).

Comment 4 Martin Entlicher 2006-07-17 13:17:12 UTC

Started to work on this, debuggerjpda/projects module will be created with
package  org.netbeans.modules.debugger.jpda.projects

Comment 5 Martin Entlicher 2006-07-17 17:15:50 UTC

Created attachment 31931 [details]
The proposed changes.

Comment 6 Martin Entlicher 2006-07-17 17:17:45 UTC

The proposed changes attached. This does not need an API review, right?
There are no API changes, just one new module from "existing sources".

Comment 7 Jesse Glick 2006-07-17 18:47:31 UTC

Should probably go to apireviews as a fast-track arch change.


BTW how much of the new module is actually specific to JPDA debugging, as
opposed to e.g. native code debugging? Looks to me that some of it is, but not
much. Something to consider.

Comment 8 Martin Entlicher 2006-07-18 10:38:42 UTC

It's actually vice-versa. The majority of the module is JPDA-specific.
What is not JPDA-specific is:
BreakpointAnnotationProvider - this is a strange class anyway and will be changed
                               most probably because of issue #63595.
DebuggerAnnotation - used by EditorContextImpl
parts of EditorContextImpl - but since it implements EditorContex, it needs to
                             stay here as it is. Only a subset of it can be made
                             available in debuggercore, if needed.

Therefore I've decided to leave things as they are. These parts can be
refactored into debuggercore module if needed.

Comment 9 Martin Entlicher 2006-07-18 10:40:32 UTC

Assigning to apireviews as a fast-track arch change as suggested.
Thanks.

Comment 10 Martin Entlicher 2006-07-24 11:13:32 UTC

Sice there were no comments to this arch change, I'm going to commit this
tomorrow. Thanks.

Comment 11 Martin Entlicher 2006-07-25 11:30:32 UTC

The change is committed to trunk:

Checking in nbbuild/cluster.properties;
/cvs/nbbuild/cluster.properties,v  <--  cluster.properties
new revision: 1.139; previous revision: 1.138
done
Checking in
debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml;
/cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml,v
 <--  mf-layer.xml
new revision: 1.33; previous revision: 1.32
done
Checking in debuggerjpda/manifest.mf;
/cvs/debuggerjpda/manifest.mf,v  <--  manifest.mf
new revision: 1.65; previous revision: 1.64
done
Checking in nbbuild/nbproject/project.xml;
/cvs/nbbuild/nbproject/project.xml,v  <--  project.xml
new revision: 1.46; previous revision: 1.45
done
Checking in ide/golden/deps.txt;
/cvs/ide/golden/deps.txt,v  <--  deps.txt
new revision: 1.294; previous revision: 1.293
done
Checking in ide/golden/files-layout.txt;
/cvs/ide/golden/files-layout.txt,v  <--  files-layout.txt
new revision: 1.148; previous revision: 1.147
done
Checking in ide/golden/modules.txt;
/cvs/ide/golden/modules.txt,v  <--  modules.txt
new revision: 1.65; previous revision: 1.64
done
Checking in debuggerjpda/nbproject/project.xml;
/cvs/debuggerjpda/nbproject/project.xml,v  <--  project.xml
new revision: 1.18; previous revision: 1.17
done
Checking in debuggerjpda/ui/nbproject/project.xml;
/cvs/debuggerjpda/ui/nbproject/project.xml,v  <--  project.xml
new revision: 1.16; previous revision: 1.15
done
Checking in debuggerjpda/ant/manifest.mf;
/cvs/debuggerjpda/ant/manifest.mf,v  <--  manifest.mf
new revision: 1.22; previous revision: 1.21
done
Checking in
debuggerjpda/ant/antsrc/org/netbeans/modules/debugger/jpda/ant/JPDAReload.java;
/cvs/debuggerjpda/ant/antsrc/org/netbeans/modules/debugger/jpda/ant/JPDAReload.java,v
 <--  JPDAReload.java
new revision: 1.11; previous revision: 1.10
done
Checking in debuggerjpda/ant/nbproject/project.properties;
/cvs/debuggerjpda/ant/nbproject/project.properties,v  <--  project.properties
new revision: 1.8; previous revision: 1.7
done
Checking in debuggerjpda/ant/nbproject/project.xml;
/cvs/debuggerjpda/ant/nbproject/project.xml,v  <--  project.xml
new revision: 1.21; previous revision: 1.20
done
Removing
debuggerjpda/ant/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider;
/cvs/debuggerjpda/ant/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider,v
 <--  org.netbeans.spi.debugger.ActionsProvider
new revision: delete; previous revision: 1.1
done
Removing
debuggerjpda/ant/src/META-INF/debugger/org.netbeans.spi.debugger.jpda.EditorContext;
/cvs/debuggerjpda/ant/src/META-INF/debugger/org.netbeans.spi.debugger.jpda.EditorContext,v
 <--  org.netbeans.spi.debugger.jpda.EditorContext
new revision: delete; previous revision: 1.1
done
Removing
debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider;
/cvs/debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider,v
 <--  org.netbeans.spi.debugger.ActionsProvider
new revision: delete; previous revision: 1.1
done
Removing
debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.jpda.SourcePathProvider;
/cvs/debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.jpda.SourcePathProvider,v
 <--  org.netbeans.spi.debugger.jpda.SourcePathProvider
new revision: delete; previous revision: 1.1
done
Removing
debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/SourcesView/org.netbeans.spi.viewmodel.NodeModel;
/cvs/debuggerjpda/ant/src/META-INF/debugger/netbeans-JPDASession/SourcesView/org.netbeans.spi.viewmodel.NodeModel,v
 <--  org.netbeans.spi.viewmodel.NodeModel
new revision: delete; previous revision: 1.1
done
Removing debuggerjpda/ant/src/META-INF/services/org.openide.text.AnnotationProvider;
/cvs/debuggerjpda/ant/src/META-INF/services/org.openide.text.AnnotationProvider,v
 <--  org.openide.text.AnnotationProvider
new revision: delete; previous revision: 1.1
done
Checking in
debuggerjpda/ant/src/org/netbeans/modules/debugger/jpda/ant/Bundle.properties;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/jpda/ant/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.4; previous revision: 1.3
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/BreakpointAnnotationProvider.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/BreakpointAnnotationProvider.java,v
 <--  BreakpointAnnotationProvider.java
new revision: delete; previous revision: 1.5
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/Bundle.properties;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/Bundle.properties,v
 <--  Bundle.properties
new revision: delete; previous revision: 1.7
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/DebuggerAnnotation.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/DebuggerAnnotation.java,v
 <--  DebuggerAnnotation.java
new revision: delete; previous revision: 1.8
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/EditorContextImpl.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/EditorContextImpl.java,v
 <--  EditorContextImpl.java
new revision: delete; previous revision: 1.29
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/FixActionProvider.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/FixActionProvider.java,v
 <--  FixActionProvider.java
new revision: delete; previous revision: 1.17
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/MainProjectManager.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/MainProjectManager.java,v
 <--  MainProjectManager.java
new revision: delete; previous revision: 1.4
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/RunToCursorActionProvider.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/RunToCursorActionProvider.java,v
 <--  RunToCursorActionProvider.java
new revision: delete; previous revision: 1.14
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/SourcePathProviderImpl.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/SourcePathProviderImpl.java,v
 <--  SourcePathProviderImpl.java
new revision: delete; previous revision: 1.14
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/SourcesNodeModel.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/SourcesNodeModel.java,v
 <--  SourcesNodeModel.java
new revision: delete; previous revision: 1.6
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/StepIntoActionProvider.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/StepIntoActionProvider.java,v
 <--  StepIntoActionProvider.java
new revision: delete; previous revision: 1.14
done
Removing
debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/ToolTipAnnotation.java;
/cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/ToolTipAnnotation.java,v
 <--  ToolTipAnnotation.java
new revision: delete; previous revision: 1.11
done
RCS file: /cvs/debuggerjpda/projects/.cvsignore,v
done
Checking in debuggerjpda/projects/.cvsignore;
/cvs/debuggerjpda/projects/.cvsignore,v  <--  .cvsignore
initial revision: 1.1
done
RCS file: /cvs/debuggerjpda/projects/build.xml,v
done
Checking in debuggerjpda/projects/build.xml;
/cvs/debuggerjpda/projects/build.xml,v  <--  build.xml
initial revision: 1.1
done
RCS file: /cvs/debuggerjpda/projects/manifest.mf,v
done
Checking in debuggerjpda/projects/manifest.mf;
/cvs/debuggerjpda/projects/manifest.mf,v  <--  manifest.mf
initial revision: 1.1
done
RCS file: /cvs/debuggerjpda/projects/nbproject/.cvsignore,v
done
Checking in debuggerjpda/projects/nbproject/.cvsignore;
/cvs/debuggerjpda/projects/nbproject/.cvsignore,v  <--  .cvsignore
initial revision: 1.1
done
RCS file: /cvs/debuggerjpda/projects/nbproject/project.properties,v
done
Checking in debuggerjpda/projects/nbproject/project.properties;
/cvs/debuggerjpda/projects/nbproject/project.properties,v  <--  project.properties
initial revision: 1.1
done
RCS file: /cvs/debuggerjpda/projects/nbproject/project.xml,v
done
Checking in debuggerjpda/projects/nbproject/project.xml;
/cvs/debuggerjpda/projects/nbproject/project.xml,v  <--  project.xml
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider,v
done
Checking in
debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider;
/cvs/debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider,v
 <--  org.netbeans.spi.debugger.ActionsProvider
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.jpda.EditorContext,v
done
Checking in
debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.jpda.EditorContext;
/cvs/debuggerjpda/projects/src/META-INF/debugger/org.netbeans.spi.debugger.jpda.EditorContext,v
 <--  org.netbeans.spi.debugger.jpda.EditorContext
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider,v
done
Checking in
debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider;
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider,v
 <--  org.netbeans.spi.debugger.ActionsProvider
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.jpda.SourcePathProvider,v
done
Checking in
debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.jpda.SourcePathProvider;
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.jpda.SourcePathProvider,v
 <--  org.netbeans.spi.debugger.jpda.SourcePathProvider
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/SourcesView/org.netbeans.spi.viewmodel.NodeModel,v
done
Checking in
debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/SourcesView/org.netbeans.spi.viewmodel.NodeModel;
/cvs/debuggerjpda/projects/src/META-INF/debugger/netbeans-JPDASession/SourcesView/org.netbeans.spi.viewmodel.NodeModel,v
 <--  org.netbeans.spi.viewmodel.NodeModel
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/META-INF/services/org.openide.text.AnnotationProvider,v
done
Checking in
debuggerjpda/projects/src/META-INF/services/org.openide.text.AnnotationProvider;
/cvs/debuggerjpda/projects/src/META-INF/services/org.openide.text.AnnotationProvider,v
 <--  org.openide.text.AnnotationProvider
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/BreakpointAnnotationProvider.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/BreakpointAnnotationProvider.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/BreakpointAnnotationProvider.java,v
 <--  BreakpointAnnotationProvider.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/Bundle.properties,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/Bundle.properties;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/Bundle.properties,v
 <--  Bundle.properties
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/DebuggerAnnotation.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/DebuggerAnnotation.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/DebuggerAnnotation.java,v
 <--  DebuggerAnnotation.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java,v
 <--  EditorContextImpl.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/FixActionProvider.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/FixActionProvider.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/FixActionProvider.java,v
 <--  FixActionProvider.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/MainProjectManager.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/MainProjectManager.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/MainProjectManager.java,v
 <--  MainProjectManager.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/RunToCursorActionProvider.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/RunToCursorActionProvider.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/RunToCursorActionProvider.java,v
 <--  RunToCursorActionProvider.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcePathProviderImpl.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcePathProviderImpl.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcePathProviderImpl.java,v
 <--  SourcePathProviderImpl.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcesNodeModel.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcesNodeModel.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/SourcesNodeModel.java,v
 <--  SourcesNodeModel.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/StepIntoActionProvider.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/StepIntoActionProvider.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/StepIntoActionProvider.java,v
 <--  StepIntoActionProvider.java
initial revision: 1.1
done
RCS file:
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/ToolTipAnnotation.java,v
done
Checking in
debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/ToolTipAnnotation.java;
/cvs/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/ToolTipAnnotation.java,v
 <--  ToolTipAnnotation.java
initial revision: 1.1
done

Comment 12 Martin Entlicher 2006-07-25 13:24:25 UTC

l10n.list adjusted as well:

/cvs/debuggerjpda/l10n.list,v  <--  l10n.list
new revision: 1.7; previous revision: 1.6

Comment 13 Quality Engineering 2010-04-29 09:17:38 UTC

Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.