This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I've found that there are two new actions related to window system: "Close Everything Else" in menu Window and "Close All But <something>" in context sensitive menu on tabs of windows in source editor. There is nothing like that in win. system spec: http://ui.netbeans.org/docs/ui/ws/ws_spec.html#3.12 Is it a bug? I don't want to say it's a bad idea to have such actions, but a) it wasn't planned b) it's wasn't discussed with author of the spec. WHY??? c) behavior of current implementation is from my point bit confusing and problematic I recommend to remove this stuff from Promo D and consider to put it to Promo E after proper discussion and design. Thanks, -Jirka
Passing to Tim, who is author of these changes. I remember talking with Tim before merge when he said he's planning to consult the change with HIE. If communication with HIE was really omitted, surely it's not good thing and we're sorry for that. But we make tons of UI changes at high pace now, and it's somewhat easy to forget to notify HIE properly. However, removing this feature from Promo D doesn't sound ideal for me. I personally like the feature and I agreed that it's useful when Tim asked me. Instead of direct total remove from Promo D, IMHO it would be better to analyze why is current implementation "confusing and problematic" (you didn't specify that in your comment). If we can agree on design and can agree on usefulness for user, then surely it would be better to modify implementation and make our product better in promo D instead of waiting for promo E.
I emailed Dusan about this prior to committing it, noting that "Close Everything Else" is lousy wording and should be changed for FCS. "Close Current File?" "Close Current Editor?" We don't use the filename in the other window system actions, and it could make the menu very wide, so I didn't want to be inconsistent with it. We have plenty of time to discuss this before promo D ships, and this is a useful and requested feature - no reason to remove it.
Guys, as I wrote in my first record. I would like to split this issue into two parts. a) how this happened (process issue) I would like to discuss it with you mainly offline. but two main points: 1) we don't have much time to spend on it now, and I'm really not happy that you are FORCING us to fix what you did this way. Can you imagine we will do the same -- change something in spec without discussing that with you and then forcing you to implement it? 2)if you "make tons of UI changes at high pace now, and it's somewhat easy to forget to notify HIE properly" you should know that from this Promo QE strictly rely on UI Spec. So if your UI changes will not be documented, they will be simply considered as high priority bugs. So consider, if it's worth it. Please check QE plan for Promo D, section "Assumptions" b) design itself Since there is no any issue or UI Spec where is described how and why this should behave, I can just guess. Anyway, here is my feedback on current state why I think the current state is bad. I don't want to deep drive on it, I would prefer to leave it on you -- Window System designers and developers to discuss and decide TOGETHER what's the right design. Jano is responsible for this stuff, but currently he is busy with WebApps usab. study and I'm not able to say now, when we will have time for it. Issues: * Window x Document From what I saw, I think that action "close everything else" works just with document (tabs in editor). In other cases it is disabled. So, is there any reason to call it windows, not document -- to be consistent with the rest of WS? * Window menu Why this action should be in Window menu? Any special reason for that? Since this action is context sensitive, I think that it should be just in popup menu on tabs, not in Window menu. It's confusing (at least for me) to see such a (disabled) action when I have selected for example Projects tab... * Popup menu: It seems to me that new names of the actions are too complicated. Why don't make them more simple? What about "Close all other windows"? or simply "Close other windows"? * Behavior: The action in popup menu should be from my point of view disabled when there is just one document, since there is nothing to close else ;-)
>From what I saw, I think that action "close everything else" works >just with document (tabs in editor). In other cases it is disabled. >So, is there any reason to call it windows, not document -- to be >consistent with the rest of WS? Correct, it works just with documents. So some way to disambiguate it from also closing explorer windows, etc. is needed. As I noted, the wording is provisional and should be changed. "Close Other Editors"? >Why this action should be in Window menu? Any special reason for that? >Since this action is context sensitive, I think that it should be just >in popup menu on tabs, not in Window menu. It's confusing (at least >for me) to see such a (disabled) action when I have selected for >example Projects tab... Initially put in the window menu for consistency with the Close action. But issues like this are exactly why I emailed Dusan about this change ahead of time (knowing Jano was busy on build system). Easy to remove. > It seems to me that new names of the actions are too complicated. Why > don't make them more simple? What about "Close all other windows"? or >simply "Close other windows"? The reason the name is included is: You can right click a tab which is not selected, and close it. Right clicking to show the popup does not change the selected tab (and it should not - switching editors is too slow, so it is impossible for the popup to be responsive enough if the tab will be changed). Including the title makes it crystal clear which tab will be closed. If you think that the corner of the popup touching the tab in question is enough indication, we can change it to "Close all but this" (the shortest wording and same as IDEA uses) and remove the title.
added core-promod. this has to be resolved before feature freeze
Fixed in trunk. I made the following changes: - Removed action from Window menu entirely - Removed file name from action display names in popup - Action is disabled if only one document present (if you'd prefer it hidden let me know) - Shortcut changed to Alt-Escape (some shortcut for this action is needed - better suggestions welcomed - most permutations of F4 are already used either by some OS's or the IDE itself) - Wording is now "Close Other Documents" - "Documents" chosen over "Close Other Tabs" for consistency with the wording of other menu items. Better wording would be "Close All Other Documents", but it starts to get long for a menu label. Checking in src/org/netbeans/core/windows/actions/ActionUtils.java; /cvs/core/windows/src/org/netbeans/core/windows/actions/ActionUtils.java,v <-- ActionUtils.java new revision: 1.9; previous revision: 1.8 done Checking in src/org/netbeans/core/windows/actions/Bundle.properties; /cvs/core/windows/src/org/netbeans/core/windows/actions/Bundle.properties,v <-- Bundle.properties new revision: 1.12; previous revision: 1.11 done Processing log script arguments... More commits to come... Checking in src/org/netbeans/core/windows/resources/layer.xml; /cvs/core/windows/src/org/netbeans/core/windows/resources/layer.xml,v <-- layer.xml new revision: 1.29; previous revision: 1.28 done Processing log script arguments... Mailing the commit message to cvs@core.netbeans.org (from tboudreau@netbeans.org)
Looks OK, thanks.
verified in [nb_dev](200408091800)