This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42910 - "Versioning" tab keeps appearing in Documents area
Summary: "Versioning" tab keeps appearing in Documents area
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: REGRESSION
: 42895 (view as bug list)
Depends on:
Blocks: 42652
  Show dependency tree
 
Reported: 2004-05-06 18:03 UTC by Jesse Glick
Modified: 2004-08-13 12:12 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Stack traces (5.83 KB, text/plain)
2004-05-06 18:04 UTC, Jesse Glick
Details
ZIP of my Windows2Local settings after cleaning and restarting a couple of times; note the multiple copies of Versioning.settings and Versioning.wstcref (33.32 KB, application/octet-stream)
2004-05-06 18:17 UTC, Jesse Glick
Details
Log of recent change, probably responsible (1.90 KB, text/plain)
2004-05-06 18:21 UTC, Jesse Glick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-05-06 18:03:22 UTC
Sometime today or recently (I use dev builds), the
"Versioning" tab started appearing the Documents
area (rather than the explorer mode as you would
expect) when I start up NB. I can close it but it
reappears anyway.

I have shut down, deleted my
$userdir/config/Windows2Local, and restarted, and
it still appears again! My window system config is
clean - and I get a Documents area with the
Welcome screen, and Versioning.

Worse, something about this component breaks
opening actual documents; I just get assertion
errors trying to use the text editor.

Note that I cannot reproduce this problem in a
fresh user directory. However neither can I find
anything in my real user directory which would
cause it. Very confused.
Comment 1 Jesse Glick 2004-05-06 18:04:37 UTC
Created attachment 14746 [details]
Stack traces
Comment 2 Jesse Glick 2004-05-06 18:14:08 UTC
dev-040505 BTW.

OK, I shut down, deleted my Windows2Local, and deleted all files in my
userdir whose name or contents contained "VCS" or "Vcs" or "vcs"
(except for a couple of parser databases). Restarted. So far so good.

Now I go to make my /space/src/nb_all CVS mount again (since I had
deleted it). Works fine, but Versioning tab mysteriously appears in
the explorer mode next to Files - I did not select the menu item to
add it there.

I close Versioning and restart. Now it is back - in the Documents mode.

Seems if I do *not* close this tab in the Documents mode, I can open
and edit regular files without errors. I just have to be sure not to
close that window or I am dead.

Note that with Versioning open in the Documents window, Window ->
Close All Documents appears to close it... but the menu item is still
enabled!
Comment 3 Jesse Glick 2004-05-06 18:15:12 UTC
*** Issue 42895 has been marked as a duplicate of this issue. ***
Comment 4 Jesse Glick 2004-05-06 18:17:50 UTC
Created attachment 14747 [details]
ZIP of my Windows2Local settings after cleaning and restarting a couple of times; note the multiple copies of Versioning.settings and Versioning.wstcref
Comment 5 Jesse Glick 2004-05-06 18:20:26 UTC
I think I found the guilty patch, will attach info.
Comment 6 Jesse Glick 2004-05-06 18:21:26 UTC
Created attachment 14748 [details]
Log of recent change, probably responsible
Comment 7 Jesse Glick 2004-05-06 18:24:04 UTC
Probably the idea in issue #42652 was to open the Versioning tab when
a VCS mount is *created*. But I think the patch actually opens it when
a mount is *restored* during startup, which presumably confuses the
window system completely because it is not expecting a window to be
opened at that time.
Comment 8 Martin Entlicher 2004-05-06 18:51:38 UTC
Aha, you're right, that patch is responsible for that.
The open on restore is an side-effect that should be removed.
The opening seems to be too low-level, I'll do something with that.
Comment 9 Jesse Glick 2004-05-06 18:58:44 UTC
Right, should probably be done in the actual Add button in VCS Manager
I guess.
Comment 10 Martin Entlicher 2004-05-06 19:34:18 UTC
You're probably right. I didn't want to do that intentionally, because
I wanted this to work with the future auto-recognition process.
But the VersioningRepository was really a bad place.
Comment 11 Martin Entlicher 2004-05-06 20:19:15 UTC
Fixed in trunk.
The original fix of issue #42652 was reverted and an opener listener
is registered in VcsManager in the New action. This is safer, but it's
bound to just VcsManager. Adding VFS into VersioningRepository without
accessing VcsManager will not open Versioning tab.

/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/fsmanager/VcsManager.java,v
 <--  VcsManager.java
new revision: 1.7; previous revision: 1.6

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/VersioningRepository.java,v
 <--  VersioningRepository.java
new revision: 1.10; previous revision: 1.9