This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42862 - Review DataSystem to not use Repository
Summary: Review DataSystem to not use Repository
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Data Systems (show other bugs)
Version: 4.x
Hardware: All All
: P1 blocker (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks: 40703
  Show dependency tree
 
Reported: 2004-05-05 17:03 UTC by Jaroslav Tulach
Modified: 2008-12-22 16:59 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2004-05-05 17:03:23 UTC 
As the buildsystem team claims that any usage
Registry is wrong and suggests to exclude any
filesystem from it while still keeping data
systems for presentation purposes without any
reasonable alternative for near future, there
seems to be a  need to evaluate the impact of such
decision and very likely update the data systems
to not relly on their filesystems being in
repository. Probably by replacing fsname/path pair
by URL.

The reviewers suggested to workaround this by
keeping backward compatibility by maitaining
"visible" filesystems in repository, which might
solve the most painful problems, but as this does
not seem to address all possible issues or it
would be a bit more complex to implement rewrite
of DS seems necessary.
Comment 1 Jesse Glick 2004-05-05 18:16:31 UTC 
Repository not Registry I think you mean.
Comment 2 Jesse Glick 2004-05-05 18:17:18 UTC 
More background in issue #42273.
Comment 3 Jesse Glick 2004-05-05 18:21:59 UTC 
From searching openide/loaders/src for Repository.getDefault I only
see issues with DataShadow (already filed). "Rewrite of DS" is surely
an exaggeration since I do not know of any other bugs in DS caused by
removing all non-default filesystems from Repository.default; if
something was really wrong I think we would have noticed by now.
Comment 4 Jaroslav Tulach 2004-05-06 09:20:23 UTC 
RepositoryListener is another suspicious piece. It is used from
DataObjectPool and its validator. How's that going to work?
Comment 5 Jesse Glick 2004-05-06 15:23:03 UTC 
Yes, a bunch of stuff can very likely be deleted from DataObjectPool
now. AFAIK it harms nothing to stay, just clutter. You don't need a
RepositoryListener for anything (ditto fsRemovedFromRepository), and
the PropertyChangeListener looks useless too since you are never going
to get a changed root or system name for the MasterFS; not sure if
this could happen to a JarFileSystem or not.
Comment 6 David Konecny 2004-05-06 16:49:41 UTC 
I will remove obsolete code from DataObjectPool.
Comment 7 David Konecny 2004-05-10 14:28:58 UTC 
DOP was cleaned up a bit:

Checking in loaders/src/org/openide/loaders/DataObjectPool.java;
new revision: 1.24; previous revision: 1.23
Checking in
test/unit/src/org/openide/loaders/DataObjectInvalidationTest.java
new revision: 1.16; previous revision: 1.15
Comment 8 Zdenek Konecny 2005-08-02 11:09:49 UTC 
Closed, too old