This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42794 - A11Y:Explorer tree no longer autoscrolls to display selection
Summary: A11Y:Explorer tree no longer autoscrolls to display selection
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Explorer (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Petr Nejedly
URL:
Keywords: A11Y, JDK_SPECIFIC, REGRESSION, UI
: 37450 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-05 02:06 UTC by Jesse Glick
Modified: 2008-12-23 14:32 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screen shot (21.04 KB, image/png)
2004-08-31 18:05 UTC, Jesse Glick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-05-05 02:06:57 UTC
I am not really sure when this changed, but I am
almost positive this is a regression from 3.6.

It used to be the case that when you selected a
node in the Explorer that was scrolled out of the
scroll area (horizontally or vertically), the
scroll pane would adjust to display it (or as much
of it as possible, starting from the left). This
no longer seems to work - of course vertical
scrolling works, but horizontal scrolling does not
happen automatically.

Not just an aspect of e.g. the Projects tab;
happens also in All Files (= old Filesystems tab,
more or less).

This is a major usability problem, IMHO.
Comment 1 Jesse Glick 2004-05-18 17:54:19 UTC
Note that you can use Ctrl-Left and Ctrl-Right to scroll horizontally,
which is occasionally useful (e.g. if a node display name is too wide
to fit in the Explorer window) but should not be required just because
you are browsing up and down nodes IMHO.
Comment 2 Jesse Glick 2004-05-31 19:07:42 UTC
*** Issue 37450 has been marked as a duplicate of this issue. ***
Comment 3 Jesse Glick 2004-05-31 19:08:29 UTC
gtzabari claims this was broken in 3.6, not promo-D.
Comment 4 Petr Nejedly 2004-06-01 09:29:08 UTC
So I looked at it.
Horizontal autoscroll partially forks for me. If i browse the explorer
using up/down arrows, it scrolls correctly in both directions (at
least on Linux, I've verified that even this is broken on windows).
If I invoke "show node in ...", it scrolls only vertically, not
horizontally. And there is one more annoyance: If I invoke "show node
in ..." and have the node already selected there (but scrolled away),
it doesn't scroll at all.
Comment 5 Petr Nejedly 2004-06-01 11:53:24 UTC
Seems it was broken by jrojcek's integration of tree table branch on
17-Apr-02. If I comment out his (strange) rectangle recomputations in
BeanTreeView.showPathWithoutExpansion, everything works correctly even
on Windows.

Jano, don't you remember why you did such modification?
Comment 6 jrojcek 2004-06-01 12:35:23 UTC
I don't remember. Sorry.
Comment 7 Petr Nejedly 2004-06-01 13:17:12 UTC
Fixed in:
openide/src/org/openide/explorer/view/BeanTreeView.java,v1.24

Also, added scrolling in case of already selected but hidden node to:
projects/projectui/src/org/netbeans/modules/project/ui/ProjectTab.java,v1.7
Comment 8 Jesse Glick 2004-06-01 14:33:13 UTC
Note re. "If i browse the explorer using up/down arrows, it scrolls
correctly in both directions (at least on Linux, I've verified that
even this is broken on windows)." - this was broken for me on Linux,
and the reason I filed this bug. I will check the next dev build.
Comment 9 _ gtzabari 2004-06-25 15:35:58 UTC
Guys, the bug still occurs as of dev build 200406211800 under JDK 1.5
beta 2. Specifically, the explorer window does not scroll horizontally
when I expand nodes that do not fit in the screen.
Comment 10 Petr Nejedly 2004-07-07 15:31:40 UTC
On subtree expansion, it scrolls only vertically, not horizontally,
right? Hmm, that may still be considered an issue but hardly P2...
Comment 11 Jesse Glick 2004-07-07 16:34:51 UTC
I guess P3 is appropriate. It does make KB navigation of deeply nested
trees very cumbersome. On the other hand, navigating such deeply
nested trees is less common in NB 4.0 compared to 3.x.
Comment 12 _ gtzabari 2004-07-07 17:47:36 UTC
Jesse, Petr,

   This is both a regression and very annoying to me. You might have
shallow working directories but mine are always very deep. This
feature was working before and it sounds like a simple bug to fix (if
only someone would take a look at it)...

    A final off topic comment, the recent Netbeans 4.0 dev builds have
been completely unusable. There has been a noticable shift from
stability to "add new features at all costs" recently and frankly it
makes the life of beta-testers like me much harder. I have finally
given up and jumped back to Netbeans 3.6. My main concern is that
there are a lot of usability problems (like the IDE forgetting your
settings when you shutdown and restart) that make using it hell. Even
Netbeans 3.6 final shipped with more visible bugs than it should have
(I remember some routine operations get exceptions on a regular
basis)... What happened to incremental development? :)
Comment 13 Petr Nejedly 2004-08-31 15:37:35 UTC
> It does make KB navigation of deeply nested trees very cumbersome.

I don't understand. If you're actually navigating the tree (moving
up/down over entries), it scrolls correctly to show most of currently
selected node. The only thing that doesn't work is horizontal
scrolling when expanding a node. Do you have the same behaviour? In
that case it makes mouse navigation worse, not the KB navigation, right?

Comment 14 Jesse Glick 2004-08-31 18:03:50 UTC
"If you're actually navigating the tree (moving up/down over entries),
it scrolls correctly to show most of currently selected node." - no,
this is precisely what does not work for me - the topic of this bug. I
will attach a screenshot. Here I have java/j2seplatform open and am
selecting a class in the Files tab, entirely using the KB. Note that
much of the label is not visible; I need to use Ctrl-Right to manually
scroll it into view.
Comment 15 Jesse Glick 2004-08-31 18:05:35 UTC
Created attachment 17263 [details]
Screen shot
Comment 16 Petr Nejedly 2004-09-01 16:17:45 UTC
That is strange, that exactly works correctly for me.
Both scrolling when navigating using up/down key and scrolling when
navigating using CS-x from editor.
Comment 17 Petr Nejedly 2004-09-01 16:26:04 UTC
Ah, I got it. Seems like a regression in Swing to me, needs more
analysis. Works perfectly on 1.4.2_05, is broken on 1.5 beta.
Comment 18 _ gtzabari 2004-09-01 17:35:56 UTC
Petr,

Please report this regression to Sun ASAP. My feeling is that they are
planning to release 5.0 final very soon and unless this issue gets
reported right away it might not get fixed for the final.
Comment 19 Petr Nejedly 2004-09-01 21:31:04 UTC
OK, verified it *is* a regression in JDK, just try running SwingSet2
both on 1.4.2 and 1.5. 
Comment 20 _ gtzabari 2004-09-02 18:19:21 UTC
Petr,

I was right, they just released JDK 5.0 RC1. Did you file the bug on
BugParade yet?
Comment 21 Petr Nejedly 2004-09-14 14:42:28 UTC
Used a workaround that sets the property JDK1.5 evaluates when
autoscrolling.
openide/src/org/openide/explorer/view/TreeView.java,v1.170
Comment 22 _ gtzabari 2004-09-19 17:55:29 UTC
I've reopened this issue because in dev build 200409151800, horizontal
scrolling still does not work in the Versioning explorer.
Comment 23 Petr Nejedly 2004-09-20 09:11:58 UTC
Works OK for me even in versioning explorer.
Comment 24 _ gtzabari 2004-09-20 13:50:10 UTC
Petr,

What build?
Comment 25 Petr Nejedly 2004-09-20 14:29:57 UTC
At least in 20040917. Anyway, versioning explorer should behave the
same way as other explorers.

When exactly doesn't it work?
Comment 26 _ gtzabari 2004-09-20 14:46:11 UTC
Using the Versioning tab, if you expand folders (using the mouse or
keyboard) deep enough, eventually some of them will fit outside the
viewable area. The tab should scroll horizontally to make them
visible, but it does not. I will try out the newer build soon but like
you I doubt there have been any recent changes.
Comment 27 Jesse Glick 2004-09-20 15:23:37 UTC
x
Comment 28 Jesse Glick 2004-09-20 15:23:55 UTC
This was FIXED, not WORKSFORME.
Comment 29 _ gtzabari 2004-09-29 17:46:06 UTC
Guys, this issue is still not fixed.

dev build 200409281800, JDK 1.5 RC, expand nodes in the Versioning tab
and it still scrolls right off the visible area.
Comment 30 _ gtzabari 2004-10-09 23:10:08 UTC
dev build 200410070525, JDK 1.5 RC, in the projects tab if you scroll
to the right as much as possible (use the mouse to drag the horizontal
scrollbar) then use the keyboard to move up/down nodes, the beginning
of the node label will be cut off (on the left). Expected behavior:
horizontal view scrolls node into view such that left-most part of
label is visible.
Comment 31 Petr Nejedly 2004-10-12 08:51:20 UTC
OK, now I see it. JTree scrolls in each direction only the amount to
not scroll out the other side.

So if you have a node so long that it is cut on both sides, it won't
autoscroll at all.
If you have your view scrolled right, it will scroll left only to fill
the gap on the right side.

I'm not going to change that behaviour unless specifically instructed
so by HIE as it may be very annoing if you scroll to see ends of nodes
and start moving up/down between them.
Comment 32 _ gtzabari 2004-10-12 14:51:55 UTC
Petr,

Sorry, but again I don't see how you can close this issue as fixed. I
don't see autoscrolling working in the versioning tab or anywhere else
for that matter. I have the tab big enough so the node can be
displayed without being cut off on both sides but it still does not
scroll. I have not noticed a single visible change since this issue
was first created. Are you *sure* you actually fixed something in the
code? If so, I honestly don't see it working. I've used clean
userdirs, the latest builds, etc and it still does not work. I also
assume you are using JDK 1.5 final under WinXP? When *does* the node
auto-scroll horizontally now that it didn't when this issue was first
created?

BTW: The behavior you mentioned (only scroll to make sure the node
fits in the visible area and don't scroll at all if the node is too
long to fit at all) is basically the desire I am looking for; except
in the latter case I would suggest auto-scroll should make sure the
*beginning* if the node is visible, regardless of whether it'll fit in
the visible region or not. Regardless of whether you make this change
or not, I expect the other functionality to be fixed before this issue
is closed as fixed :)

We need to figure out if you and I are using different configuration
which is preventing you from seeing this issue on your end.
Comment 33 Petr Nejedly 2004-10-12 16:17:11 UTC
OK, you're right. I went to an XP box (I don't use Windows myself) and
tried it there. It really doesn't work. I'm sorry to tell you I'm not
going to fix it, as the behaviour is controlled by PLAF and the
behaviour under the XP LAF is consistent with WinXP behaviour (try it
in windows explorer). If you try another LAF (such as Metal),
autoscroll will work for you even on WinXP.

I'm closing this as FIXED as I have really fixed (on 09/14/2004) the
original bug - autoscroll wasn't working at all on JDK1.5, not even
using Metal LAF.

Comment 34 _ gtzabari 2004-10-12 20:24:09 UTC
Petr,

Thanks for the response. I agree with your assessment that Explorer
doesn't auto-scroll either so it is likely that the Windows L&F is
applying this same behavior.

I am curious whether it would be possible for me to file a RFE to add
a "force autoscroll" feature to Netbeans that would enable
autoscrolling regardless of the L&F setting. Is this technical
possible or does the Windows L&F not expose a property to force this
behavior?
Comment 35 Tomas Danek 2005-07-15 09:10:24 UTC
This does not occure in latest builds of 4.2 on sol/sparc Metal LnF. If there
are no more such problems on windows, I'll verify.
Comment 36 Tomas Danek 2005-07-21 08:47:18 UTC
closing
Comment 37 Quality Engineering 2008-12-23 14:32:10 UTC
This issue had *1 votes* before move to platform component