This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42743 - HTML renderer integration increased tree view cell height a bit
Summary: HTML renderer integration increased tree view cell height a bit
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 4.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: _ tboudreau
URL:
Keywords: REGRESSION, UI
Depends on:
Blocks:
 
Reported: 2004-05-03 20:37 UTC by Jesse Glick
Modified: 2008-12-22 15:54 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Before shot (10.05 KB, image/png)
2004-05-03 20:37 UTC, Jesse Glick
Details
After shot; looks like a lazy student trying to make a term paper look longer than it is :-) (11.48 KB, image/png)
2004-05-03 20:38 UTC, Jesse Glick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-05-03 20:37:10 UTC
After the HTML renderer integration, my tree views
(e.g. Projects tab) are using a slightly larger
cell height, which looks slightly odd and wastes a
little vertical space. Went from 16 pixels to 18
pixels. Intentional?

I am using Metal on JDK 1.5.0 b48. See screenshots.
Comment 1 Jesse Glick 2004-05-03 20:37:32 UTC
Created attachment 14674 [details]
Before shot
Comment 2 Jesse Glick 2004-05-03 20:38:06 UTC
Created attachment 14675 [details]
After shot; looks like a lazy student trying to make a term paper look longer than it is :-)
Comment 3 _ tboudreau 2004-05-03 21:17:51 UTC
Checking in src/org/openide/awt/HtmlLabelUI.java;
/cvs/openide/src/org/openide/awt/HtmlLabelUI.java,v  <--  HtmlLabelUI.java
new revision: 1.3; previous revision: 1.2
done
Comment 4 Jesse Glick 2004-05-03 22:37:32 UTC
Thanks, that was fast!
Comment 5 Jesse Glick 2004-05-04 19:42:42 UTC
Hmm, but I just made a fresh dev build and opened it on my same user
dir, and it is still 18 pixels.
Comment 6 _ tboudreau 2004-05-05 10:51:18 UTC
The algorithm is correct; it was broken before (even with -fontsize 30, tree cells were 
always 16px).  It is:

Math.max (18, fontMetrics.getHeight())

18 is necessary so the focus border does not overlap the icon (and so icons are not on top 
of each other if they don't contain an internal margin) - icon height of 16 + 1px above and 
below.

However, I've added support for "Jesse mode" - run with
-J-Dnb.cellrenderer.fixedheight=12 
or whatever

So this is as fixed as it's going to get...

Checking in src/org/openide/awt/HtmlLabelUI.java;
/cvs/openide/src/org/openide/awt/HtmlLabelUI.java,v  <--  HtmlLabelUI.java
new revision: 1.4; previous revision: 1.3
done
Processing log script arguments...
More commits to come...
Checking in src/org/openide/explorer/view/TreeView.java;
/cvs/openide/src/org/openide/explorer/view/TreeView.java,v  <--  TreeView.java
new revision: 1.161; previous revision: 1.160
done
Comment 7 Jesse Glick 2004-05-05 19:19:26 UTC
OK, so long as it is intentional.
Comment 8 Marian Mirilovic 2004-06-30 09:06:05 UTC
verified