This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42478 - [perf] Expand All action in the refactoring window is not responsive
Summary: [perf] Expand All action in the refactoring window is not responsive
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 4.x
Hardware: PC All
: P2 blocker (vote)
Assignee: Jan Becicka
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2004-04-26 17:20 UTC by Antonin Nebuzelsky
Modified: 2007-04-03 18:02 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2004-04-26 17:20:39 UTC
Expand All Nodes action in the refactoring window
(Usages of "foo") is blocking AWT thread and even
though it can take many seconds there is no
indication of it. This action must be changed to
behave according to the rules for UI Responsiveness.

The best approach would be to correct its
behaviour according to the current number of nodes
in the tree and assessment of the time needed. If
the tree can be expanded within 100ms, no
indication is needed, if it can be expanded within
1s, only hour-glass cursor can be used, if it
takes more than 1s a progress bar should be provided.
Comment 1 Jan Becicka 2004-04-29 11:40:46 UTC
Fixed. Wait cursor added.
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/Attic/RefactoringPanel.java,v
 <--  RefactoringPanel.java
new revision: 1.1.2.12.2.4; previous revision: 1.1.2.12.2.3
done
Comment 2 psuk 2004-05-25 08:58:47 UTC
Setting Target Milestone to promoD
Comment 3 Antonin Nebuzelsky 2004-06-11 11:22:36 UTC
Sorry, have to reopen. The wait cursor is useful but the IDE is frozen
until the expand action finishes (done fully in AWT) which can take
many seconds.

Would it be possible to prepare the expanded tree in a separate thread
and only replace the old tree with the new one in AWT thread when the
new tree is ready?
Comment 4 Jan Becicka 2004-06-16 11:03:54 UTC
OK. I'll try it, but handling AWT components outside AWT thread is not
a good practise.
Comment 5 Jan Becicka 2004-06-18 11:42:23 UTC
Checking in RefactoringPanel.java;
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/RefactoringPanel.java,v
 <--  RefactoringPanel.java
new revision: 1.8; previous revision: 1.7
done
Comment 6 Antonin Nebuzelsky 2004-06-21 17:09:14 UTC
Verified. Thanks.