This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42477 - [perf] Populating of o.n.m.refactoring.ui.RefactoringPanel is done in AWT thread
Summary: [perf] Populating of o.n.m.refactoring.ui.RefactoringPanel is done in AWT thread
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 4.x
Hardware: PC All
: P2 blocker (vote)
Assignee: Jan Becicka
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2004-04-26 17:05 UTC by Antonin Nebuzelsky
Modified: 2007-04-03 18:02 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Populating refactoring window in AWT thread blocking the whole UI (gray) without any progress indication (14.01 KB, text/plain)
2004-05-19 15:49 UTC, Antonin Nebuzelsky 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2004-04-26 17:05:24 UTC 
Refactoring, as present in meta_stavbicka branch,
does have progress bar for Where Used
functionality and does not do its main workload
blocking the UI.

But the last phase of the action, initialization
of the window Usages of "foo" is done after the
progress bar window is dismissed, in AWT thread,
thus blocking UI. This must be changed and also
this last phase of the action must be covered by
the progress bar indication.
Comment 1 Jan Becicka 2004-04-29 11:40:39 UTC 
Fixed. ProgressBar added.
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/Attic/RefactoringPanel.java,v
 <--  RefactoringPanel.java
new revision: 1.1.2.12.2.4; previous revision: 1.1.2.12.2.3
done
Comment 2 Antonin Nebuzelsky 2004-05-19 15:47:43 UTC 
Have to reopen. Still having the same problem w/ build 040518. See the
thread dump in attachment...
Comment 3 Antonin Nebuzelsky 2004-05-19 15:49:02 UTC 
Created attachment 15009 [details]
Populating refactoring window in AWT thread blocking the whole UI (gray) without any progress indication
Comment 4 Jan Becicka 2004-05-20 08:32:19 UTC 
Fixed.
Checking in RefactoringPanel.java;
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/Attic/RefactoringPanel.java,v
 <--  RefactoringPanel.java
new revision: 1.1.2.12.2.9; previous revision: 1.1.2.12.2.8
done

BTW this fix reduces number of needed parses from 3 to 2.
As Martin described in issue 43296, we are going to use lazy iterator
to reduce number of parses to 1.
Comment 5 Antonin Nebuzelsky 2004-05-21 10:02:14 UTC 
Verified in meta_stavbicka build 040521.
Looks good!