This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39386 - Unauthorized CVS commits in the web & j2eeserver modules
Summary: Unauthorized CVS commits in the web & j2eeserver modules
Status: RESOLVED INVALID
Alias: None
Product: obsolete
Classification: Unclassified
Component: collabnet (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: issues@www
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-29 19:19 UTC by Ana.von Klopp
Modified: 2009-11-08 02:33 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
CVS commit logs (4.04 KB, text/plain)
2004-01-29 19:21 UTC, Ana.von Klopp
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ana.von Klopp 2004-01-29 19:19:54 UTC
Please address this urgently, as we are close to a 
beta release and cannot afford to have 
unauthorized, unreviewed changes.

There has been a source commit in the web module 
by "genero" who is a member with observer access 
but who does not have developer access. 

There has also been a source commit in the 
j2eeserver module by "capSS" who is not a member 
of this module at all. 

I will attach the CVS logs.
Comment 1 Ana.von Klopp 2004-01-29 19:21:36 UTC
Created attachment 13149 [details]
CVS commit logs
Comment 2 jcatchpoole 2004-01-30 10:30:52 UTC
Both genero and capSS have "grandfather" access, hence are allowed to
commit anywhere.

I've never heard of either of them, and I did not grant them that 
access.  Policy is to mail nbdev with any new requests for grandfather
access, unfortunately I think not everyone follows this procedure.

I can't find any posts to nbdev including those usernames.

There are very few people who could have granted this access - I'm
cc'ing some of them.  New cc-ees, do you know :

a) who they are
b) who granted them grandfather
c) if they really should have grandfather

I'm assuming the commits weren't malicious - we can always contact 
them and ask for an explanation ?
Comment 3 Petr Jiricka 2004-01-30 14:32:53 UTC
I strongly agree that for all users with grandfather access, we should
know the identity of these users. Is it possible to at least find out
when they were granted grandfather access, if not by whom?

I think there were good intentions behind those commits, however, when
we are close to the release cycle, there should be some shared
understanding regarding the direction of the codeline.
Comment 4 Petr Jiricka 2004-01-30 15:07:40 UTC
Ok, now we know the identity of both these users - they are
contractors from a sustaining group in Russia, but it would still be
useful to find out how they got grandfather access.
Comment 5 Ana.von Klopp 2004-01-30 17:12:51 UTC
Also, although the commits are not malicious, they have been updating 
bugs, marking bugs as invalid or enhancements based on a 
misunderstanding of what the bug report meant. It is very time 
consuming for us to have to reopen bugs because of these invalid 
assessments. 
Comment 6 jcatchpoole 2004-02-02 12:07:22 UTC
Well I was hoping for an update telling us who gave htem the privs by 
now  ...

I'm not sure what to do here.  They are real users, someone gave them
grandfather for some reason, so we can't just remove the accts.  I
also can't just remove commit privs to web & j2ee, it would be better
to know explicitly what modules they need commit perms for, and then
just add them (and nothing else).

Wow I just found that the "Audit log" in SourceCast works!  For a very 
long time it has been broken.  Anyway, I've found who granted this 
access (the same person did for both accounts), and I'll need to ask 
them for details of why.

Ana, Petr, what would you like to do ?  Is removal of their commit 
privs to the modules in question necessary, or is the answer just 
better communication/policy on who commits where ?
Comment 7 Petr Jiricka 2004-02-02 12:21:23 UTC
It sounds to me that these contributors were given commit privileges
by virtue of being Sun contractors.

It's not necessary to remove commit privileges now, there are other
means how we can address our issues (solution already in progress).
Comment 8 jcatchpoole 2004-02-03 11:25:31 UTC
OK.  Looks like we might change the way grandfather roles are handled,
or even remove the role alltogether.  That's another discussion ... but 
in the short, what to do with this issue ?
Comment 9 Petr Jiricka 2004-02-03 16:18:57 UTC
Changing to INVALID, as this is clearly not the infrastructure bug,
but our process issue. Will address it in a different way.
Comment 10 Marian Mirilovic 2009-11-08 02:33:07 UTC
We recently moved out from Collabnet's infrastructure